Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve assert messages in stream-pipe-await-drain-manual-resume #16884

Closed
wants to merge 1 commit into from
Closed

test: improve assert messages in stream-pipe-await-drain-manual-resume #16884

wants to merge 1 commit into from

Conversation

katie-roberts
Copy link
Contributor

Failing test error message improved so will return the expected and actual value returned.

Checklist

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 8, 2017
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 8, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11309/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 8, 2017
@katie-roberts @Trott
test: improve assert messages in stream test
d597317 
In test-stream-pipe-await-train-manual-resume, include unexpected value
in error messages.

PR-URL: nodejs#16884
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 8, 2017

Landed in d597317.
Thanks for the contribution! 🎉

@Trott Trott closed this Nov 8, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@katie-roberts @evanlucas
test: improve assert messages in stream test
172652b 
In test-stream-pipe-await-train-manual-resume, include unexpected value
in error messages.

PR-URL: #16884
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@katie-roberts @MylesBorins
test: improve assert messages in stream test
0bc16cd 
In test-stream-pipe-await-train-manual-resume, include unexpected value
in error messages.

PR-URL: #16884
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@katie-roberts @MylesBorins
test: improve assert messages in stream test
5e4de71 
In test-stream-pipe-await-train-manual-resume, include unexpected value
in error messages.

PR-URL: #16884
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@katie-roberts @MylesBorins
test: improve assert messages in stream test
8550fbc 
In test-stream-pipe-await-train-manual-resume, include unexpected value
in error messages.

PR-URL: #16884
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@katie-roberts @MylesBorins
test: improve assert messages in stream test
6686440 
In test-stream-pipe-await-train-manual-resume, include unexpected value
in error messages.

PR-URL: #16884
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@katie-roberts @vsemozhetbyt @Trott @addaleax @gireeshpunathil @MylesBorins @nodejs-github-bot