Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add isTTY property documentation #16828

Closed
wants to merge 1 commit into from
Closed

doc: add isTTY property documentation #16828

wants to merge 1 commit into from

Conversation

sonaysevik
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc

@sam-github

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tty Issues and PRs related to the tty subsystem. labels Nov 6, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@sam-github
Copy link
Contributor

@sonaysevik FYI, PRs have to sit for 2 work days to give folks a chance to review, then they can be landed.

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11254/

@joyeecheung
Copy link
Member

@sam-github I think we have relaxed the rule a bit recently. In the collaborator guide it's now documented as:

Before landing pull requests, sufficient time should be left for input from other Collaborators. Leave at least 48 hours during the week and 72 hours over weekends to account for international time differences and work schedules. Trivial changes (e.g. those which fix minor bugs or improve performance without affecting API or causing other wide-reaching impact), and focused changes that affect only documentation and/or the test suite, may be landed after a shorter delay if they have multiple approvals.

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
@sonaysevik @Trott
doc: add isTTY property documentation
37c1188 
PR-URL: nodejs#16828
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 7, 2017

Landed in 37c1188.
Thanks for the contribution! 🎉

@Trott Trott closed this Nov 7, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@sonaysevik @cjihrig
doc: add isTTY property documentation
978aa84 
PR-URL: nodejs#16828
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@sonaysevik @MylesBorins
doc: add isTTY property documentation
fab5598 
PR-URL: #16828
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@sonaysevik @MylesBorins
doc: add isTTY property documentation
dece265 
PR-URL: #16828
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@sonaysevik @MylesBorins
doc: add isTTY property documentation
0a156b4 
PR-URL: #16828
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@sonaysevik @MylesBorins
doc: add isTTY property documentation
02e6aa5 
PR-URL: #16828
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@sonaysevik @MylesBorins
doc: add isTTY property documentation
14ffddd 
PR-URL: #16828
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sonaysevik @sam-github @joyeecheung @Trott @cjihrig @gireeshpunathil @MylesBorins @nodejs-github-bot