-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspector: include node_platform.h header #16677
inspector: include node_platform.h header #16677
Conversation
Include the header instead of using a forward declaration.
@gireeshpunathil Is it normal that CI jobs are in the pending state for almost 3 days already? |
Include the header instead of using a forward declaration. PR-URL: #16677 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@alexeykuzmin - actually the CI has been completed in time, but the view in github is not updated to reflect that fact - probably a bug - @nodejs/collaborators - please share any prior art on this if you know. Landed in 916e1cb , thanks for the contribution! |
Yeah, bug in the bot used to update that stuff. I think @maclover7 recently fixed it or was working on fixing it. |
@gireeshpunathil @Trott Build statuses should be reporting properly for all |
Include the header instead of using a forward declaration. PR-URL: nodejs#16677 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Include the header instead of using a forward declaration. PR-URL: #16677 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Include the header instead of using a forward declaration. PR-URL: #16677 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
When Node.js is compiled as a part of the Electron build clang generates a couple of errors (see below). Including a header instead of using a forward declaration fixes them.
It would be great if the code could be changed in the Node.js repo so Electron wouldn't have to have a patch for that.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
inspector