Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodejs/gyp team #16638

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Add nodejs/gyp team #16638

merged 1 commit into from
Nov 2, 2017

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Oct 31, 2017

It would be good to have a GYP team to cc/ in issues.

I know @refack and @bnoordhuis have done a fair amount of work on GYP in the past, not sure who else has experience there, maybe @seishun ?

If you want to be on the team, reply here and I'll add you 😁 .

I also formatted the table while I was there. Happy to change it back if people prefer unevenness to long lines.

Checklist
Affected core subsystem(s)

doc, build

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 31, 2017
@gireeshpunathil
Copy link
Member

does this confirm #16633 (comment) ?

@gibfahn
Copy link
Member Author

gibfahn commented Oct 31, 2017

does this confirm #16633 (comment) ?

Sort of. We could still upstream things to GYP itself, but whether we should keep doing that is something the members of nodejs/gyp could decide.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR-URL: nodejs#16638
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@gibfahn gibfahn merged commit 8bb2a2d into nodejs:master Nov 2, 2017
@gibfahn gibfahn deleted the doc-gyp branch November 2, 2017 22:43
@gibfahn
Copy link
Member Author

gibfahn commented Nov 2, 2017

Team created, it could do with some more members though...

@maclover7
Copy link
Contributor

Just noticed when looking at the teams page that there's now a "gyp" team as well as a "node-gyp" team. Should they be combined?

@refack
Copy link
Contributor

refack commented Nov 2, 2017

Just noticed when looking at the teams page that there's now a "gyp" team as well as a "node-gyp" team. Should they be combined?

node-gyp are people with write bit in https://github.com/nodejs/node-gyp (which is actually mostly node.js core around GYP).
AFAICT the purpose on the new gyp team is to review and maintain the GYP tool, and .gyp files related to the build scaffolding of node core (which is more python focussed)

@gibfahn
Copy link
Member Author

gibfahn commented Nov 2, 2017

Just noticed when looking at the teams page that there's now a "gyp" team as well as a "node-gyp" team. Should they be combined?

As @refack says, they are different teams with different purposes.

cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
PR-URL: nodejs#16638
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
gibfahn added a commit that referenced this pull request Nov 14, 2017
PR-URL: #16638
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.