Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused includes in string_bytes.h #16606

Closed
wants to merge 1 commit into from
Closed

src: remove unused includes in string_bytes.h #16606

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Oct 30, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Oct 30, 2017
joyeecheung
joyeecheung reviewed Oct 30, 2017
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy: https://ci.nodejs.org/job/node-test-pull-request/11090/

@joyeecheung
Copy link
Member

Also heads up for a rebase since #16548 is about to land

@danbev danbev force-pushed the remove-unused-include-string_bytes branch from 4a9ad7c to 68ee77f Compare October 30, 2017 11:27
@danbev
Copy link
Contributor Author

danbev commented Nov 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11124/

@tniessen
Copy link
Member

tniessen commented Nov 1, 2017

Most (if not all) failures appear to be unrelated, VS2013 seem to fail compilation on all CI builds.

@danbev
Copy link
Contributor Author

danbev commented Nov 1, 2017

Landed in 54946b6

@danbev danbev closed this Nov 1, 2017
danbev added a commit that referenced this pull request Nov 1, 2017
@danbev
src: remove unused includes in string_bytes.h
54946b6 
PR-URL: #16606
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: XadillaX <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danbev danbev deleted the remove-unused-include-string_bytes branch November 1, 2017 07:56
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@danbev @Qard
src: remove unused includes in string_bytes.h
f1db2e1 
PR-URL: nodejs/node#16606
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: XadillaX <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@danbev @Qard
src: remove unused includes in string_bytes.h
cd13f17 
PR-URL: nodejs/node#16606
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: XadillaX <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
@danbev @cjihrig
src: remove unused includes in string_bytes.h
4f8765d 
PR-URL: nodejs#16606
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: XadillaX <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
Merged
gibfahn pushed a commit that referenced this pull request Nov 14, 2017
@danbev @gibfahn
src: remove unused includes in string_bytes.h
79e1d77 
PR-URL: #16606
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: XadillaX <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@danbev @addaleax
src: remove unused includes in string_bytes.h
22ae393 
PR-URL: nodejs/node#16606
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: XadillaX <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danbev @joyeecheung @tniessen @cjihrig @XadillaX @gireeshpunathil @gibfahn @MylesBorins @nodejs-github-bot