Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update http test client function signatures #15807

Closed
wants to merge 1 commit into from
Closed

test: update http test client function signatures #15807

wants to merge 1 commit into from

Conversation

Alkagar
Copy link
Contributor

@Alkagar Alkagar commented Oct 6, 2017 •
edited
Loading

remove unused head arguments

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@Alkagar Alkagar force-pushed the test/http-upgrade-client2 branch from ae8cdc7 to ea0ec96 Compare October 6, 2017 16:44
@Alkagar Alkagar changed the title test:update http test client function signatures test: update http test client function signatures Oct 6, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@Trott
Copy link
Member

Trott commented Oct 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10469/

@Trott Trott self-assigned this Oct 11, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 11, 2017
@Alkagar @Trott
test: update http test client function signatures
b3ce408 
remove unused head arguments

PR-URL: nodejs#15807
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 11, 2017

Landed in b3ce408.

Thanks for the contribution! 🎉

@Trott Trott closed this Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@Alkagar @addaleax
test: update http test client function signatures
6ee5ce5 
remove unused head arguments

PR-URL: nodejs/node#15807
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@Alkagar @targos
test: update http test client function signatures
cbbb229 
remove unused head arguments

PR-URL: #15807
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@Alkagar @MylesBorins
test: update http test client function signatures
9d54b21 
remove unused head arguments

PR-URL: #15807
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@Alkagar @MylesBorins
test: update http test client function signatures
18d03e1 
remove unused head arguments

PR-URL: #15807
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@Alkagar @MylesBorins
test: update http test client function signatures
e3e234e 
remove unused head arguments

PR-URL: #15807
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@rmg rmg rmg approved these changes

Assignees

@Trott Trott

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.