benchmark,path: remove unused variables #15789
Conversation
nodejs-github-bot
added
the
lib / src
|
The changes to lib/path.js appear legit, but IMHO it would be better to have them in a separate PR. |
|
Also, changes to dependencies should be made in those projects' respective upstream repositories instead of node's repository. The only remaining change is the change to benchmark/fs/read-stream-throughput.js which seems legit also. In that case, the commit message for this PR should be changed to target the benchmark subsystem (when all of the other changes are removed). |
aladdin-add
force-pushed
the
chore/linting
branch
from
3c93b49 to
20dd55f
Compare
|
sorry for the delay. I reset the changes in my local testing failing somehow, but should not be related to the changes -- it was the same when reverting all changes.
friendly ping @mscdex @bnoordhuis |
|
I think the commit message should be changed if we're going to keep these two changes together. Perhaps something like "benchmark,path: remove unused variables" because our linter currently does not fail without the changes, so the current message is misleading. |
aladdin-add
force-pushed
the
chore/linting
branch
from
20dd55f to
76f740e
Compare
aladdin-add
changed the title
|
friendly ping @bnoordhuis (。・∀・)ノ |
|
Ping @bnoordhuis PTAL |
|
Ping @bnoordhuis your comment seems to be addressed. |
|
Hi @bnoordhuis — it seems your feedback here might've been addressed. Would you mind giving it a look? Thanks! |
BridgeAR
dismissed
bnoordhuis’s stale review
The comment was addressed and seems resolved. PTAL
BridgeAR
added
the
author ready
PR-URL: #15789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in fbb9eef |
addaleax
removed
the
author ready
PR-URL: #15789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #15789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #15789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #15789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #15789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
some are detected by eslint.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)