crypto: migrate Certificate to internal/errors #15756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move argument type checking to js, use internal/errors
jasnell
added
errors
nodejs-github-bot
added
c++
lpinca
approved these changes
Oct 5, 2017
joyeecheung
approved these changes
Oct 8, 2017
|
Ok. I can separate those out |
|
@nodejs/tsc ... ping? Please review? |
addaleax
approved these changes
Oct 14, 2017
|
@jasnell Feel free to land this now, if you don’t like to go by @joyeecheung’s suggestion, it would be nice if you could backport the doc changes manually so they aren’t lost just because they are in a semver-major PR :) |
| function verifySpkac(spkac) { | ||
| if (!isArrayBufferView(spkac)) { | ||
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'spkac', | ||
| ['Buffer', 'TypedArray', 'DataView']); |
There was a problem hiding this comment.
Why only spkac doesn't have string in the error message?
There was a problem hiding this comment.
don't know. This was the way it was already. We can add string as an option in a separate follow on commit
|
I'll do a backport PR for the docs later. |
jasnell
added a commit
that referenced
this pull request
Oct 15, 2017
Move argument type checking to js, use internal/errors PR-URL: #15756 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 3ddc88b |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
Move argument type checking to js, use internal/errors PR-URL: nodejs/node#15756 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move argument type checking to js, use internal/errors
Improve docs and tests
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto