test: fix assert.throws in test-http-invalid-urls #15678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Sep 29, 2017
|
|
||
| function test(host) { | ||
| ['get', 'request'].forEach((method) => { | ||
| [http, https].forEach((module) => { | ||
| assert.throws(() => module[method](host, () => { | ||
| common.expectsError(() => module[method](host, () => { | ||
| throw new Error(`${module}.${method} should not connect to ${host}`); |
There was a problem hiding this comment.
Nit: how about replacing this with common.mustNotCall()?
There was a problem hiding this comment.
Sure. And while I'm at it, I can add { and } around the arrow function body because there's no need for it to implicitly return a value.
There was a problem hiding this comment.
Found other problems in the process. Refactored/fixed/commented in the commit message.
hiroppy
approved these changes
Sep 29, 2017
cjihrig
approved these changes
Sep 29, 2017
jasnell
approved these changes
Sep 29, 2017
Trott
force-pushed
the
assert-throws-booboo
branch
from
f19a178 to
5db3a8b
Compare
When the second argument to `assert.throws()` is a string, it is not treated as the expected error message but rather the message that the assertion should display if no error is thrown. Ths change fixes that error in `test-http-invalid-urls.js`. Instead of skipping the test when there is no crypto, the test is now run but with `http` only. `https` is skipped. Logging was fixed. Previously, errors would be written out as being in the `[object Object]` module rather than `http` or `https`.
Trott
force-pushed
the
assert-throws-booboo
branch
from
5db3a8b to
a263630
Compare
BridgeAR
approved these changes
Sep 30, 2017
|
Landed in 2e215f1 |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 1, 2017
When the second argument to `assert.throws()` is a string, it is not treated as the expected error message but rather the message that the assertion should display if no error is thrown. Ths change fixes that error in `test-http-invalid-urls.js`. Instead of skipping the test when there is no crypto, the test is now run but with `http` only. `https` is skipped. Logging was fixed. Previously, errors would be written out as being in the `[object Object]` module rather than `http` or `https`. PR-URL: #15678 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
When cherry-picked to 8.x this test is failing. Could you please backport |
|
@MylesBorins The test change is dependent on #14423 which is semver-major. I'll label this "dont-land" on 8, 6, and 4. |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
When the second argument to `assert.throws()` is a string, it is not treated as the expected error message but rather the message that the assertion should display if no error is thrown. Ths change fixes that error in `test-http-invalid-urls.js`. Instead of skipping the test when there is no crypto, the test is now run but with `http` only. `https` is skipped. Logging was fixed. Previously, errors would be written out as being in the `[object Object]` module rather than `http` or `https`. PR-URL: nodejs/node#15678 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the second argument to
assert.throws()is a string, it is nottreated as the expected error message but rather the message that the
assertion should display if no error is thrown. Ths change fixes that
error in
test-http-invalid-urls.js.Instead of skipping the test when there is no crypto, the test is now
run but with
httponly.httpsis skipped.Logging was fixed. Previously, errors would be written out as being in
the
[object Object]module rather thanhttporhttps.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test