Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore: ignore test-npm artifacts #1567

Closed
wants to merge 1 commit into from
Closed

gitignore: ignore test-npm artifacts #1567

wants to merge 1 commit into from

Conversation

Fishrock123
Copy link
Contributor

See #1549, these files are produced while running make test-npm.

R=@othiym23

@Fishrock123 Fishrock123 added test Issues and PRs related to the tests. npm Issues and PRs related to the npm client dependency or the npm registry. labels Apr 30, 2015
@othiym23
Copy link
Contributor

othiym23 commented May 1, 2015

This could be landed, but I think a better solution would be to fix the relevant test(s) in npm to not treat fixtures as mutable, and to update the test-npm stanza in the io.js Makefile to clean up the .bin directory after running the tests. .bin doesn't need to be included for distribution (which is part of why the release tarball doesn't include it). Rather than clutter the build tree, we should keep working on this until the test suite is idempotent.

@Fishrock123 Fishrock123 mentioned this pull request May 1, 2015
Closed
@Fishrock123
Copy link
Contributor Author

Ok, doing that. some make test-npm cleanup is at #1576, and I'll look into fixing that test from npm.

@Fishrock123 Fishrock123 closed this May 1, 2015
@Fishrock123 Fishrock123 deleted the gitignore-npm-artifacts branch May 12, 2015 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fishrock123 @othiym23