inspector: migrate to internal/errors #15619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
errors
nodejs-github-bot
added
errors
|
Ping @nodejs/tsc |
jasnell
added
the
semver-major
lpinca
approved these changes
Sep 26, 2017
BridgeAR
reviewed
Sep 26, 2017
lib/inspector.js
Outdated
| throw new TypeError( | ||
| `"params" must be an object, got ${typeof params} instead`); | ||
| throw new errors.TypeError('ERR_INVALID_ARG_TYPE', | ||
| 'params', 'Object', params); |
There was a problem hiding this comment.
Other errors mainly use 'object' (lower cased).
|
Do we not have any tests for the inspector error cases? |
|
@BridgeAR ... none that were affected... which is a bit scary. |
|
@jasnell would you be so kind and add some for those? I think it would be a shame not to use the opportunity otherwise. |
|
Sure :-) gimme a couple of days tho. |
80 tasks
jasnell
force-pushed
the
inspector-internal-errors
branch
from
6aac4f2 to
81cf213
Compare
|
Test added! |
jasnell
force-pushed
the
inspector-internal-errors
branch
2 times, most recently
from
6c1c982 to
5bf3c97
Compare
jasnell
force-pushed
the
inspector-internal-errors
branch
from
5bf3c97 to
3498510
Compare
|
Ping @nodejs/tsc ... review please? |
joyeecheung
approved these changes
Oct 14, 2017
lib/internal/errors.js
Outdated
| @@ -236,6 +236,10 @@ E('ERR_HTTP_INVALID_STATUS_CODE', | |||
| E('ERR_HTTP_TRAILER_INVALID', | |||
| 'Trailers are invalid with this transfer encoding'); | |||
| E('ERR_INDEX_OUT_OF_RANGE', 'Index out of range'); | |||
| E('ERR_INSPECTOR_ALREADY_CONNECTED', 'Already connected'); | |||
There was a problem hiding this comment.
Nit: The inspector is already connected?
jasnell
added a commit
that referenced
this pull request
Oct 16, 2017
PR-URL: #15619 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
|
Landed in 4cf56ad |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
PR-URL: nodejs/node#15619 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate to internal/errors
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector,errors