v6.11.4 proposal #15506
Merged
v6.11.4 proposal #15506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport-PR-URL: #14390 PR-URL: #13726 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14244 Reviewed-By: Alexey Orlenko <[email protected]>
This PR adds cpp linting to windows build script. After this change, running command `vcbuild lint` will run both cpp linting and javascript linting on a windows machine. Backport-PR-URL: #14879 PR-URL: #11856 Fixes: #11816 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
180bec1 PR-URL: #11992 Fixes: #11971 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. Backport-PR-URL: #14879 PR-URL: #14116 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: João Reis <[email protected]>
Backport-PR-URL: #14899 PR-URL: #13497 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes. This PR use common.platformTimeout and widen the time gap. PR-URL: #14677 Ref: #14674 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Original commit message:
[PATCH] [debugger] Scope iterator should not visit inner function literals.
[email protected]
BUG=chromium:621361
Review-Url: https://codereview.chromium.org/2185913003
Cr-Commit-Position: refs/heads/master@{#38087}
Fixes: #15075
PR-URL: #15215
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
The functionality of ESLint custom rule assert-throws-arguments can be replaced with no-restricted-syntax entries. Backport-PR-URL: #15253 PR-URL: #14547 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Original commit message: Avoid disassembling Interpreted Regexp code I found that v8 will crash when --print-code is turned on while Regexp is interpreted. It crashes when trying to print Relocation info during Disassembly. It should probably avoid printing out disassembly when the Code object is a bytecode regexp. Bug: Change-Id: I35b531cb03996a303248652871452266c78fee38 Reviewed-on: https://chromium-review.googlesource.com/642127 Reviewed-by: Yang Guo <[email protected]> PR-URL: #15287 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <[email protected]>
This fix makes ... in REPL to be considered as a javascript construct rather than a REPL keyword. Fixes: #14426 Backport-PR-URL: #14915 PR-URL: #14467 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Backport-PR-URL: #14841 PR-URL: #14061 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Unchecked argument conversion in Parser::Consume crashes node in an slightly undesirable manner - 'unreachable code' in parser. Make sure we validate the incoming type at the earliest point. PR-URL: #12288 Fixes: #12178 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #9447 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: #14364 Fixes: #14362 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Also issuerCertificate but that did not fit on the status line. Fixes: #11771 PR-URL: #14473 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Fix a bug when messages bigger than 64kb where incorrectly parsed by the inspector-helper. PR-URL: #14596 Fixes: #14507 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
On Debian with OpenSSL 1.1 CLI, the ciphers used in those tests were unknown. PR-URL: #14566 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
* Add common/countdown utility * Numerous improvements to http tests PR-URL: #14315 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #14616 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
The check for `os.networkInterfaces()` in `test-os.js` may be too strict. It's apparently possible for a machine to be configured with multiple IPv4 loopback interfaces. Increase specificity of filter to check on only the object we expect. PR-URL: #14655 Fixes: #14654 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14706 Fixes: #8728 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
The sanity_check AtExit callback needs to come last to verify that the other callbacks have been completed. This was not noticed before as this code was not been executed. PR-URL: #14048 Reviewed-By: Michaël Zasso <[email protected]>
When working on commit 0d95a0b ("test: remove undef NDEBUG from at-exit addons test) I searched for usages of undef NDEBUG but did not include the doc directory (but I did include the test directory) and missed this one. Commit 1f02569f8db9cb0101807df4982534738f0161b2 ("tools: fix tools/addon-verify.js") enables the code in the "AtExit" section to be included in the test/addons diretory and this code will again be tested. PR-URL: #14048 Reviewed-By: Michaël Zasso <[email protected]>
The current implementation of addon-verify.js is including the code for the "Function arguments" section in test/addons/01_callbacks and there is no directory generated or the "Function arguments section". This continues and leads to the last section, "AtExit", code to be excluded. There is an test/addons/07_atexit_hooks but it contains code from the "Passing wrapped objects around" section. This commit modifies addon-verify to associate headers with code and then iterates over the set and generates the files as a separate step. PR-URL: #14048 Reviewed-By: Michaël Zasso <[email protected]>
Reset the underlying socket of an HTTP stream to be marked as unconsume after the HTTP parser no longer owns it. Fixes: #14407 PR-URL: #14410 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
In test/parallel/test-module-loading-error.js, an attempt is made to load a text file as a native executable. This results in an error message in a platform specific manner. AIX was not included in the list of platforms. This fix introduces the AIX error messages. PR-URL: #14511 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Use block-scoping in test-readline-interface to avoid side effects and make tests more modular. (Some contain race conditions and will need to be moved to the sequential directory if they can't be refactored to avoid the race condition.) Backport-PR-URL: #14748 Backport-Reviewed-By: Anna Henningsen <[email protected]> PR-URL: #14615 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14485 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit documents and edge-case behavior in readable streams. It is expected that non-object streams are measured in bytes against the highWaterMark. However, it was discovered in issue thereafter begin to measure the buffer's length in characters. PR-URL: #13442 Refs: #6798 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
We are currenly builing Node with --shared-zlib which happens to be version 1.2.8. The test for zlib.createDeflateRaw is expected to fail but does not when using version 1.2.8. As far as I can tell the fix referred to in the comments was introduced in version 1.2.9: - Reject a window size of 256 bytes if not using the zlib wrapper This commit suggests adding a check for the version and skipping this assert if the version is less than 1.2.9. Refs: http://zlib.net/ChangeLog.txt Backport-PR-URL: #15478 PR-URL: #13697 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Keepalive sockets that are returned to the agent's freesocket pool were previously capturing a reference to the ClientRequest that initiated the request. This commit eliminates that by moving the installation of the socket listeners to a different function. Backport-PR-URL: #15500 PR-URL: #10134 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
1. Rename private functions 2. Use destructuring 3. Remove obsolete comments Backport-PR-URL: #15516 PR-URL: #13862 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Backport-PR-URL: #15516 PR-URL: #13862 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #14845 Backport-PR-URL: #15557 Fixes: #14823 Refs: #14822 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
force-pushed
the
v6.11.4-proposal
branch
from
a810d0a to
be4eab5
Compare
MylesBorins
added a commit
that referenced
this pull request
Sep 26, 2017
Notable Changes: Coming Soon PR-URL: #15506
mscdex
removed
build
|
CI is green 🎉 running citgm one more time citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1003/ |
Each page of the API documentation should have links to other versions of the same page. This will make it easier to switch between the current "live" release at nodejs.org and LTS versions. Backport-PR-URL: #15670 PR-URL: #10958 Fixes: #10726 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Backport-PR-URL: #15670 PR-URL: #15063 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Backport-PR-URL: #15670 PR-URL: #15420 Fixes: #15396 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
force-pushed
the
v6.11.4-proposal
branch
from
be4eab5 to
bd7bb04
Compare
MylesBorins
added a commit
that referenced
this pull request
Sep 29, 2017
Notable Changes: Coming Soon PR-URL: #15506
|
CITGM looks good. Updated docs generator, one more run + r.c. to check it out ci: https://ci.nodejs.org/job/node-test-pull-request/10338/ |
MylesBorins
force-pushed
the
v6.11.4-proposal
branch
from
bd7bb04 to
8691fdf
Compare
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
Notable Changes:
* net:
- support passing undefined to listen() to match behavior in v4.x
and v8.x (Sam Roberts)
nodejs/node#14234
PR-URL: nodejs/node#15506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-10-03, Version 6.11.4 'Boron' (LTS), @MylesBorins
This LTS release comes with 91 commits. This includes 29 which are test related,
28 which are doc related, 11 which are build / tool related and 3 commits which are updates to dependencies.
Notable Changes
Commits
73416b46e4] - assert: refactor the code (Ruben Bridgewater) #13862a8b917ee2f] - benchmark: fix dgram/bind-params.js benchmark (Rich Trott) #14948855d7ae326] - benchmark: convert var to es6 const (Sebastian Murphy) #128866a7e46ed9c] - build: add NetBSD support to opensslconf.h (Roy Marples) #1431366dd898be8] - build: better support for python3 systems (Ben Noordhuis) #1473714cc1abb56] - build: split up cpplint to avoid long cmd lines (Kyle Farnung) #14116c9ae894277] - build: add lint option to vcbuild.bat help (Morgan Brenner) #1199266cdcd9d5b] - build: add cpp linting to windows build (liusi) #1185625be2a3be3] - crypto: naming anonymous functions. (solebox) #89934e1a50a079] - deps: backport 0353a1e from V8 upstream (jBarz) #15287921876dcd1] - deps: backport 071b655 from V8 upstream (Michaël Zasso) #15215a13ac69ff9] - doc: prevent displaying empty version picker (Chris Young) #15420ecea33b277] - doc: add links to alternative versions of doc (Chris Young) #10958feb6863a5c] - doc: document bytes to chars after setEncoding (Jessica Quynh Tran) #1344233fdbb5417] - doc: describe what security issues are (Sam Roberts) #14485a260190717] - doc: instructions for generating coverage reports (Simon Brewster) #151901b0e660c25] - doc: /s/SHASUM256/SHASUMS256 (Jon Moss) #151015696223534] - doc: clarify http.get data consumption requirement (AJ Jordan) #150494c26913dab] - doc: crypto.randomBytes does not block when async (Sam Roberts) #14993605a02b613] - doc: environmental->environment & NodeJS->Node.js (Rod Vagg) #14974b10bc31030] - doc: fix typo in Buffer.from(string, [encoding]) (Michał Wadas) #1501329de000938] - doc: add note for Windows build path (Kyle Lamse) #143547546eef262] - doc: rephrase text of child_process.execSync() (hafiz) #1495370e9a6ece3] - doc: link to correct "OS Constants" heading in docs (James Kyle) #1496955dc14ec61] - doc: remove misterdjules from the CTC members list (Julien Gilli) #1498c76a54f318] - doc: add missing word (Jon Moss) #1492427b6737d85] - doc: explain what to do if git push is rejected (Rich Trott) #14848d75e9b7d44] - doc: add BridgeAR to collaborators (Ruben Bridgewater) #14862a63cd82003] - doc: fix word wrapping for api stability boxes (Saad Quadri) #14809f8fbac7842] - doc: improve fs.read() doc text (Rich Trott) #146315a7a49f505] - doc: clarify the position argument for fs.read (dcharbonnier) #14631b5904a2054] - doc: remove undef NDEBUG from addons.md (Daniel Bevenius) #14048c0e47e4f22] - doc: fix order of AtExit callbacks in addons.md (Daniel Bevenius) #14048dcdc9053b4] - doc: fix typo in stream.md (Marc Hernández Cabot) #14364594e3c2115] - doc: add readline.emitKeypressEvents note (Samuel Reed) #944790fcccd7a3] - doc: add documentation on ICU (Timothy Gu) #1391638ae5c4e34] - doc, lib, test: do not re-require needlessly (Vse Mozhet Byt) #14244abf6355936] - doc,assert: document stackStartFunction in fail (Ruben Bridgewater) #13862f0328f631a] - doc,stream: remove wrong remark on readable.read (Jan Schär) #150140c670e0339] - http: eliminate capture of ClientRequest in Agent (Evan Torrie) #1013467074113dc] - http: reset stream to unconsumed inunconsume()(Anna Henningsen) #14410e65c9ec7f4] - http: assert parser.consume argument's type (Gireesh Punathil) #122884e717820a0] - lib: clean up usage of threw (Jackson Tian) #10534e014178362] - meta: merge TSC and CTC back into a single body (James M Snell) #149734ee066eaba] - meta: considerations for new core modules (James M Snell) #15022948a7d70e7] - meta: improve definition of a collaborator (James M Snell) #14981caeee38b1d] - net: support passing undefined to listen() (Sam Roberts) #14234792acc17bf] - net: fix abort on bad address input (Ruben Bridgewater) #137268604772960] - readline: remove max limit of crlfDelay (Azard) #13497362a7c0d8b] - repl: do not consider...as a REPL command (Shivanth MP) #14467968121bbfe] - src: remove unnecessary helper function (Brian White) #14959b2112f8d36] - src: detect nul bytes in InternalModuleReadFile() (Ben Noordhuis) #14854d20b7bfb6e] - src: use local isolate instead of args.GetIsolate (Daniel Bevenius) #1476866187fa044] - stream: fix Writable instanceof for subclasses (Anna Henningsen) #149452c8fe9748c] - test: remove envPlus, use Object.assign everywhere (Gibson Fahnestock) #148458e00315506] - test: check zlib version for createDeflateRaw (Daniel Bevenius) #136972babae4cd4] - test: refactor test-fs-readfile-unlink (Rich Trott) #151738b045747e0] - test: pipe some error output if npm fails (Jeremiah Senkpiel) #124906540e99547] - test: simplify test-tls-client-default-ciphers (Jon Moss) #14928ad1d745498] - test: extend async addon test (Anna Henningsen) #149221e231ba8c7] - test: add known issue for vm module (Franziska Hinkelmann) #14661644d9905a0] - test: do not modify fixtures in test-fs-chmod (Rich Trott) #14926168f73c5f4] - test: improve assertion fail messages (Refael Ackermann) #14949915b56b963] - test: remove unused arguments from function (Ankit Parashar) #14931724508295d] - test: make timers-blocking-callback more reliable (Rich Trott) #148314fb4fbea1c] - test: add missing console.error to exec-maxBuffer (Beth Griggs) #14796a284ee6129] - test: invoke callback with common.mustCall() (Griffith Tchenpan) #859732260b91f2] - test: check crypto before requiring tls module (Daniel Bevenius) #1470868cf7f0b30] - test: improve multiple zlib tests (James M Snell) #14455f35f06d04c] - test: improve multiple vm tests (James M Snell) #144581aac05b087] - test: cover all HTTP methods that parser supports (Oky Antoro) #147739f330250b5] - test: remove redundantusingin cctest (XadillaX) #1473991649b913c] - test: make test-tls-connect checks more strict (Rich Trott) #146959ed2c4cb0e] - test: add block scoping to test-readline-interface (Rich Trott) #146154fb755c432] - test: set module loading error for aix (Prakash Palaniappan) #145119d8464161e] - test: fix conversion of microseconds in test (Nick Stanish) #1470628b77d1f8b] - test: improve check in test-os (Rich Trott) #14655fc49cf41ea] - test: improve multiple timers tests (James M Snell) #14616c88f99f1f3] - test: improvements to various http tests (James M Snell) #14315860c6198c0] - test: use ciphers supported by shared OpenSSL (Jérémy Lal) #145668b9a05c04b] - test: read proper inspector message size (Bartosz Sosnowski) #1459686497f1acc] - test: mark inspector-port-zero-cluster as flaky (Refael Ackermann)8dfc2838c8] - test: fix test-readline-interface (Azard) #146773a6392b283] - tls: fix empty issuer/subject/infoAccess parsing (Ben Noordhuis) #1447337dd2adbac] - tools: fix linter error in html.js (Michaël Zasso) #150638b3ac4b2a2] - tools: add custom private key option (Ruslan Bekenev) #14401cac4beb764] - tools: fix update-eslint.sh (Myles Borins) #14850debea1c531] - tools: delete an unused argument (phisixersai) #14251ca61f3bd80] - tools: fix tools/addon-verify.js (Daniel Bevenius) #14048f7b6d198b9] - tools: eslint - useerrorandoff(Refael Ackermann) #14061f8b85e16cd] - tools: replace assert-throw-arguments custom lint (Rich Trott) #14547