build: fix dtrace-enabled build on os x #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch fixes the problem for me. |
Commit 691d55f introduces a regression on OS X when dtrace is enabled (the default.) This commit rectifies that by removing the erroneous platform check. Fixes the following build error: CXX(target) /Users/bnoordhuis/src/iojs/out/Release/obj.target/node/src/node_dtrace.o ../src/node_dtrace.cc:27:10: fatal error: 'node_provider.h' file not found PR-URL: nodejs#150 Reviewed-By: Miroslav Bajtoš <[email protected]>
bnoordhuis
force-pushed
the
fix-osx-dtrace-build
branch
from
c04146a to
0fbe528
Compare
|
I was just about to report this myself, good timing! |
boingoing
added a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
napi: Remove napi_propertyname
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 691d55f introduces a regression on OS X when dtrace is enabled
(the default.) This commit rectifies that by removing the erroneous
platform check.
Fixes the following build error:
R=@bajtos, /cc @evantorrie