Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add missing new line to printed message #13940

Closed
wants to merge 1 commit into from
Closed

src: add missing new line to printed message #13940

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@TimothyGu TimothyGu added c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface. labels Jun 27, 2017
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 27, 2017
@TimothyGu
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8839/

@TimothyGu TimothyGu added the i18n-api Issues and PRs related to the i18n implementation. label Jun 27, 2017
@refack
Copy link
Contributor

refack commented Jun 27, 2017 •
edited
Loading

Re CI — the PIs are not well, so I killed the test after 4h
Ref: nodejs/build#774

@refack refack mentioned this pull request Jun 27, 2017
Closed
@TimothyGu
Copy link
Member Author

Landed in 9330835.

@TimothyGu TimothyGu closed this Jun 29, 2017
@TimothyGu TimothyGu deleted the printf-newline branch June 29, 2017 08:02
TimothyGu added a commit that referenced this pull request Jun 29, 2017
@TimothyGu
src: add missing new line to printed message
9330835 
PR-URL: #13940
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 29, 2017
@TimothyGu @addaleax
src: add missing new line to printed message
82dc65b 
PR-URL: #13940
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@addaleax addaleax mentioned this pull request Jun 29, 2017
Merged
@tniessen
Copy link
Member

This was landed despite having unresolved CI problems on Windows, e.g. https://ci.nodejs.org/job/node-test-binary-windows/9461/RUN_SUBSET=0,VS_VERSION=vcbt2015,label=win10/console

Ref #13986

tniessen added a commit to tniessen/node that referenced this pull request Jun 29, 2017
@tniessen
src: revert 13940
8573ce8 
PR broke tests on Windows.

Ref: nodejs#13940
@tniessen tniessen mentioned this pull request Jun 29, 2017
Closed
2 tasks
addaleax pushed a commit that referenced this pull request Jun 29, 2017
@tniessen @addaleax
test: fix failure in test-icu-data-dir.js
e7ff3b9 
This fixes a broken test on Windows caused by EOL conversion.

PR-URL: #13987
Refs: #13940
Refs: #13986
Reviewed-By: Refael Ackermann <[email protected]>
@TimothyGu
Copy link
Member Author

@tniessen Sorry about that, I overlooked the Windows results thinking they were just another infrastructure issue. Will be more careful.

addaleax pushed a commit that referenced this pull request Jul 11, 2017
@TimothyGu @addaleax
src: add missing new line to printed message
d5c14fe 
PR-URL: #13940
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@tniessen @addaleax
test: fix failure in test-icu-data-dir.js
6289b11 
This fixes a broken test on Windows caused by EOL conversion.

PR-URL: #13987
Refs: #13940
Refs: #13986
Reviewed-By: Refael Ackermann <[email protected]>
@tniessen tniessen mentioned this pull request Jul 17, 2017
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@TimothyGu @addaleax
src: add missing new line to printed message
dff506c 
PR-URL: #13940
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@tniessen @addaleax
test: fix failure in test-icu-data-dir.js
fa9e647 
This fixes a broken test on Windows caused by EOL conversion.

PR-URL: #13987
Refs: #13940
Refs: #13986
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@TimothyGu @MylesBorins
src: add missing new line to printed message
8de2eca 
PR-URL: #13940
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
@TimothyGu @MylesBorins
src: add missing new line to printed message
42b825b 
PR-URL: #13940
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@TimothyGu @MylesBorins
src: add missing new line to printed message
35f9111 
PR-URL: #13940
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@TimothyGu @refack @tniessen @danbev @jasnell @lpinca @cjihrig @MylesBorins @nodejs-github-bot