Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade libuv to 1.12.0 #13306

Merged
merged 3 commits into from
Jun 7, 2017
Merged

deps: upgrade libuv to 1.12.0 #13306

merged 3 commits into from
Jun 7, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 30, 2017

If anyone knows of any Node.js issues that are resolved by this release, please link them here so they can be added to the commit metadata, and closed on landing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. labels May 30, 2017
@cjihrig cjihrig requested review from saghul and removed request for saghul May 30, 2017 17:22
@BridgeAR
Copy link
Member

BridgeAR commented May 30, 2017

Solves #12853. As far as I see it, it's the only issue closed by the upgrade.

@@ -0,0 +1,9 @@
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely this file can be ignored?

@Fishrock123
Copy link
Contributor

Fishrock123 commented May 30, 2017

I believe one of the oldest still-open issues, #854, is fixed by this?

Assuming unix: remove FSEventStreamFlushSync() call is in this release.

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Anyone have opinions on whether to gitignore the uvbook files in docs/code and docs/src/guide? It adds another ~100 kB to the tarball (240 kB uncompressed) and I don't expect many people will look at it.

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

The support code for older systems is still there but going forward we won't bend over backwards to keep it in working shape.

@jasnell
Copy link
Member

jasnell commented May 30, 2017

+1 to ignoring the uvbook files

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM but I'd like to see a CITGM run before this lands.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp approval from me as well provided CI passes.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 1, 2017

@bnoordhuis should the uvbook be explicitly added to .gitignore, or just not checked in?

@bnoordhuis
Copy link
Member

@cjihrig I'd add it to the .gitignore, that prevents accidental check-ins in the future.

@cjihrig cjihrig force-pushed the uv branch 2 times, most recently from cf680b8 to 59b0847 Compare June 1, 2017 17:03
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 1, 2017

Removed the uvbook and .github folders. PTAL

@richardlau
Copy link
Member

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

We should also raise Node.js' minimum supported levels in BUILDING.md to match.

@cjihrig cjihrig force-pushed the uv branch 2 times, most recently from 871ed57 to 9b40352 Compare June 5, 2017 01:43
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 5, 2017

Added a commit to update BUILDING.md.

@bnoordhuis
Copy link
Member

Still LGTM. The raised baseline might become non-academic in the future, see libuv/libuv#1372.

@Fishrock123
Copy link
Contributor

@cjihrig could you please move the .gitignore change into it's own commit?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 5, 2017

Moved to separate commit. CI: https://ci.nodejs.org/job/node-test-pull-request/8482/

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 5, 2017

CI seemed good. Ran CITGM (https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/854/). Can someone help interpreting the output?

@gibfahn
Copy link
Member

gibfahn commented Jun 5, 2017

cc/ @nodejs/citgm

@bricss bricss mentioned this pull request Jun 5, 2017
cjihrig added 2 commits June 7, 2017 09:30
Fixes: nodejs#12853
Fixes: nodejs#854
PR-URL: nodejs#13306
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
The libuv 1.12.0 update bumped the minimum supported version
of linux + glibc. This commit updates BUILDING.md to reflect
the new values.

PR-URL: nodejs#13306
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
jasnell added a commit to jasnell/node that referenced this pull request Jun 7, 2017
* **Async Hooks**
  * When one `Promise` leads to the creation of a new `Promise`, the parent
    `Promise` will be identified as the trigger
    [[`135f4e6643`](nodejs@135f4e6643)]
    [nodejs#13367](nodejs#13367).
* **Dependencies**
  * libuv has been updated to 1.12.0
    [[`968596ec77`](nodejs@968596ec77)]
    [nodejs#13306](nodejs#13306).
  * npm has been updated to 5.0.3
    [[`ffa7debd7a`](nodejs@ffa7debd7a)]
    [nodejs#13487](nodejs#13487).
* **File system**
  * The `fs.exists()` function now works correctly with `util.promisify()`
    [[`6e0eccd7a1`](nodejs@6e0eccd7a1)]
    [nodejs#13316](nodejs#13316).
  * fs.Stats times are now also available as numbers
    [[`c756efb25a`](nodejs@c756efb25a)]
    [nodejs#13173](nodejs#13173).
* **Inspector**
  * It is now possible to bind to a random port using `--inspect=0`
    [[`cc6ec2fb27`](nodejs@cc6ec2fb27)]
    [nodejs#5025](nodejs#5025).
* **Zlib**
  * A regression in the Zlib module that made it impossible to properly
    subclasses `zlib.Deflate` and other Zlib classes has been fixed.
    [[`6aeb555cc4`](nodejs@6aeb555cc4)]
    [nodejs#13374](nodejs#13374).
rvagg pushed a commit that referenced this pull request Jun 8, 2017
* **Async Hooks**
  * When one `Promise` leads to the creation of a new `Promise`, the parent
    `Promise` will be identified as the trigger
    [[`135f4e6643`](135f4e6643)]
    [#13367](#13367).
* **Dependencies**
  * libuv has been updated to 1.12.0
    [[`968596ec77`](968596ec77)]
    [#13306](#13306).
  * npm has been updated to 5.0.3
    [[`ffa7debd7a`](ffa7debd7a)]
    [#13487](#13487).
* **File system**
  * The `fs.exists()` function now works correctly with `util.promisify()`
    [[`6e0eccd7a1`](6e0eccd7a1)]
    [#13316](#13316).
  * fs.Stats times are now also available as numbers
    [[`c756efb25a`](c756efb25a)]
    [#13173](#13173).
* **Inspector**
  * It is now possible to bind to a random port using `--inspect=0`
    [[`cc6ec2fb27`](cc6ec2fb27)]
    [#5025](#5025).
* **Zlib**
  * A regression in the Zlib module that made it impossible to properly
    subclasses `zlib.Deflate` and other Zlib classes has been fixed.
    [[`6aeb555cc4`](6aeb555cc4)]
    [#13374](#13374).
rvagg pushed a commit that referenced this pull request Jun 8, 2017
* **Async Hooks**
  * When one `Promise` leads to the creation of a new `Promise`, the parent
    `Promise` will be identified as the trigger
    [[`135f4e6643`](135f4e6643)]
    [#13367](#13367).
* **Dependencies**
  * libuv has been updated to 1.12.0
    [[`968596ec77`](968596ec77)]
    [#13306](#13306).
  * npm has been updated to 5.0.3
    [[`ffa7debd7a`](ffa7debd7a)]
    [#13487](#13487).
* **File system**
  * The `fs.exists()` function now works correctly with `util.promisify()`
    [[`6e0eccd7a1`](6e0eccd7a1)]
    [#13316](#13316).
  * fs.Stats times are now also available as numbers
    [[`c756efb25a`](c756efb25a)]
    [#13173](#13173).
* **Inspector**
  * It is now possible to bind to a random port using `--inspect=0`
    [[`cc6ec2fb27`](cc6ec2fb27)]
    [#5025](#5025).
* **Zlib**
  * A regression in the Zlib module that made it impossible to properly
    subclasses `zlib.Deflate` and other Zlib classes has been fixed.
    [[`6aeb555cc4`](6aeb555cc4)]
    [#13374](#13374).
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
@MylesBorins MylesBorins added backport-requested-v6.x semver-minor PRs that contain new features and should be released in the next minor version. labels Jul 17, 2017
@MylesBorins
Copy link
Contributor

Can we get this backported to v6.x for a future semver minor

@bnoordhuis bnoordhuis mentioned this pull request Aug 16, 2017
2 tasks
@MylesBorins
Copy link
Contributor

@cjihrig @bnoordhuis do you see any issues with backporting this to v6.x? The minimal version of kernel + libc are slightly worrysome, but your comments appear to imply that it isn't a big deal.

@gibfahn
Copy link
Member

gibfahn commented Sep 19, 2017

Could we backport this version without backporting the supported versions update? @bnoordhuis you mentioned that it was academic for this release, and this is likely to be the last libuv update for 6.x.

@bnoordhuis
Copy link
Member

None of the support code for old kernels was removed so yes, this is safe to back-port.

MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
Fixes: #12853
Fixes: #854
PR-URL: #13306
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
PR-URL: #13306
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@cjihrig cjihrig mentioned this pull request Oct 16, 2017
2 tasks
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
Fixes: #12853
Fixes: #854
PR-URL: #13306
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #13306
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
MylesBorins added a commit that referenced this pull request Nov 6, 2017
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263
MylesBorins added a commit that referenced this pull request Nov 7, 2017
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263
@uttampawar
Copy link
Contributor

Is there a timeline when this can land? Thanks.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 14, 2018

Land where? Node 6 is the oldest supported release line and it has a newer version of libuv than this.

@uttampawar
Copy link
Contributor

@cjihrig I thought that content of libuv/libuv#1372 is getting pulled in as part of this PR which I realized is not the case. I apologize for the confusion, it was misunderstanding on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.