stream: add final method #12828

calvinmetcalf · 2017-05-04T14:29:32Z

Adds the ability to for write streams to have an _final method which acts
similarly to the _flush method that transform streams have but is called before
the finish event is emitted and if asynchronous delays the stream from
finishing. The final option may also be passed in order to set it.

this is a new version of #2314 as discussed at nodejs/readable-stream#275, cc @nodejs/streams

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

vsemozhetbyt · 2017-05-04T17:03:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7860/

mscdex · 2017-05-04T19:24:29Z

lib/_stream_writable.js

+    if (typeof stream._final === 'function') {
+      state.pendingcb++;
+      state.finalCalled = true;
+      process.nextTick(() =>


Can we please use braces here for multi-line arrow function bodies?

mscdex · 2017-05-04T19:24:57Z

lib/_stream_writable.js

+          state.prefinished = true;
+          stream.emit('prefinish');
+          finishMaybe(stream, state);
+        })


Missing semicolon.

Actually, this is still the function argument, it seems no semicolon is needed here (linter is OK).

Ah, CI is still down so I cannot see the test results.

mscdex · 2017-05-04T19:57:02Z

New CI post-Jenkins restart: https://ci.nodejs.org/job/node-test-pull-request/7865/

addaleax · 2017-05-04T23:23:26Z

doc/api/stream.md

+
+When the stream ends this function will be called before the stream closes,
+useful if you need to close a resource or write some data that you had buffered.
+This function is completely optional to implement.


I think we should mention in the _flush documentation how the two relate

Also, please avoid using you in the documentation :)

I think we should mention in the _flush documentation how the two relate

Mentioning this with flush asks the question, why would one use flush instead of this, and I'd probably recommend using this instead of flush but we had decided to postpone the discussion on whether to soft depreciate flush or not.

addaleax · 2017-05-04T23:27:26Z

test/parallel/test-stream-transform-final.js

+
+const t = new stream.Transform({
+  objectMode: true,
+  transform: function(chunk, _, next) {


I think practically all of the callbacks here should be wrapped in common.mustCall(function[, n])

Seeing as how this specific callback could be called multiple times, I'm not sure we should use one in this case (so as not to rely on streams' internal behavior as much).

In object mode it should definitely be called a fixed number of times, I think?

Ah yeah, for object mode perhaps it will be.

Side note: I've been stewing over a modification for mustCall that would allow us to say 'at least once' as opposed to a fixed count

@jasnell I'd probably prefer a separate method to make it more easy to tell vs. a flag or extra argument for mustCall().

addaleax · 2017-05-04T23:27:57Z

test/parallel/test-stream-transform-final.js

+    assert.strictEqual(++state, chunk + 2, 'transformCallback part 2');
+    process.nextTick(next);
+  },
+  final: function(done) {


Any reason for switching between done and next? 😄

traditionally I use next for the callback with transform and done for the name with flush so final seemed like it would be similar to flush.

addaleax · 2017-05-04T23:30:37Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/762/

calvinmetcalf · 2017-05-05T09:31:36Z

pushed more commits that remove the second person pronoun from the docs, fix a doc link, and fixes some style issues, I will be happy squash these l before we merge

calvinmetcalf · 2017-05-09T12:27:56Z

@addaleax are these CITGM errors related to the pull?

addaleax · 2017-05-09T12:32:00Z

@calvinmetcalf No, that look “fine” :)

addaleax

LGTM with one suggestion that should definitely be part of this PR. I would prefer for the common.mustCall() wraps to be added here too, but if not, somebody else can do that afterwards.

addaleax · 2017-05-09T12:33:10Z

doc/api/stream.md

@@ -1359,6 +1364,19 @@ The `writable._writev()` method is prefixed with an underscore because it is
 internal to the class that defines it, and should never be called directly by
 user programs.

+#### writable.\_final(callback)


addressed, ignore me
please add ``` ```
directly below this heading :)

calvinmetcalf · 2017-05-09T12:46:57Z

common.mustCall()

I can add this if you want, in any palce in particular

addaleax · 2017-05-09T12:49:23Z

@calvinmetcalf It would make sense to use that for any callbacks that are invoked a fixed number of times (and at least those callbacks containing assertions)

calvinmetcalf · 2017-05-09T13:00:41Z

ok I'll update the tests

addaleax · 2017-05-09T13:52:49Z

Fresh CI: https://ci.nodejs.org/job/node-test-commit/9751/

mcollina · 2017-05-09T14:14:09Z

lib/_stream_writable.js

+    if (typeof stream._final === 'function') {
+      state.pendingcb++;
+      state.finalCalled = true;
+      process.nextTick(() => {


are we sure we should call this with nextTick?

I think so, let me see if I can come up with a test that effects it

yeah so if that is call synchronously, then if the callback in final is called synchronously then the finish event will be called before the _flush method

Ok, would you mind extracting those closures into top-level functions?

are you also talking about stream._final((err) => { one because I'm not sure we can extract that one

we could put a handler on writable state I guess

let's keep stream._final((err) => { as it is.

but that would involve a bind so I'm not sure if that's a win overall

mcollina

LGTM

calvinmetcalf · 2017-05-09T17:14:03Z

ok I'll squash

jasnell

LGTM with a couple of suggestions

jasnell · 2017-05-09T20:18:43Z

doc/api/stream.md

+* `callback` {Function} Call this function (optionally with an error
+  argument) when you are done writing any remaining data.
+
+Note: **This function MUST NOT be called directly.**  It MAY be implemented


*Note*: This function **must not** be called directly...

jasnell · 2017-05-09T20:19:07Z

doc/api/stream.md

+
+When the stream ends this function will be called before the stream closes,
+useful if to close a resource or write some data that that is buffered.
+This function is completely optional to implement.


omit completely

Also that that is buffered.

Suggested reword:

This optional function will be called before the stream closes, delaying the finish event until callback is called. This is useful to close resources or write buffered data before a stream ends.

mcollina · 2017-05-09T20:50:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7972/

(this also need a run with CITGM with and without the READABLE_STREAM flag)

calvinmetcalf · 2017-05-10T11:56:36Z

@jasnell pushed up your doc fixes

calvinmetcalf · 2017-05-10T12:17:59Z

@TomFrost updated with your suggestion

jasnell · 2017-05-10T19:19:42Z

doc/api/stream.md

+by child classes, and if so, will be called by the internal Writable
+class methods only.
+
+This optional function will be called before the stream closes, delaying the `finish` event until `callback` is called. This is useful to close resources or write buffered data before a stream ends.


Please line break at <= 80 chars

Thank you. This LGTM. If CI is green and @nodejs/streams signs off it should be good to go as far as I'm concerned.

lpinca · 2017-05-22T14:18:59Z

It seems unrelated. That test basically writes to a destroyed socket and expects the socket.write() callback to have an error.

refack · 2017-05-22T17:22:45Z

I had to kill https://ci.nodejs.org/job/citgm-smoker/814/nodes=fedora22/ it got stuck (maybe at ws). ~~IMHO 815 would be enough.~~ killed 815 too. There was nothing of note in the previous run on fedora22, and it's a post EOL platform anyway.

refack · 2017-05-22T17:41:09Z

CITGM clean 👍

calvinmetcalf · 2017-05-24T15:00:00Z

ok are we waiting on anything for this one ?

mcollina · 2017-05-24T15:31:14Z

You can go ahead and land.

A fresh CI: https://ci.nodejs.org/job/node-test-pull-request/8281/

refack

Approve CITGM is clean.
Rubber stamp code.

calvinmetcalf · 2017-05-24T17:21:04Z

ba513d1

Adds the ability to for write streams to have an _final method which acts similarly to the _flush method that transform streams have but is called before the finish event is emitted and if asynchronous delays the stream from finishing. The `final` option may also be passed in order to set it. PR-URL: #12828 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

marshall007 · 2017-05-25T05:23:28Z

@calvinmetcalf FYI, there appear to be duplicate lines on lib/_stream_writable.js#L64-L66.

mcollina · 2017-05-25T08:53:48Z

good spot @marshall007!

calvinmetcalf · 2017-05-25T12:20:24Z

woops will open a fix

Adds the ability to for write streams to have an _final method which acts similarly to the _flush method that transform streams have but is called before the finish event is emitted and if asynchronous delays the stream from finishing. The `final` option may also be passed in order to set it. PR-URL: #12828 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](nodejs@4a7233c178)] [nodejs#12892](nodejs#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](nodejs@d2d32ea5a2)] [nodejs#11968](nodejs#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](nodejs@7eb1b4658e)] [nodejs#12141](nodejs#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](nodejs@beca3244e2)] [nodejs#10236](nodejs#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](nodejs@97a77288ce)] [nodejs#12348](nodejs#12348), [[`d75fdd96aa`](nodejs@d75fdd96aa)] [nodejs#10423](nodejs#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](nodejs@627ecee9ed)] [nodejs#10653](nodejs#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](nodejs@f18e08d820)] [nodejs#9744](nodejs#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](nodejs@3c3b36af0f)] [nodejs#12936](nodejs#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](nodejs@60d1aac8d2)] [nodejs#12784](nodejs#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](nodejs@84dabe8373)] [nodejs#12489](nodejs#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](nodejs@7a55e34ef4)] [nodejs#10467](nodejs#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](nodejs@3c2a9361ff)] [nodejs#9683](nodejs#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](nodejs@90403dd1d0)] [nodejs#11567](nodejs#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](nodejs@d3480776c7)] [nodejs#11259](nodejs#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](nodejs@fb71ba4921)] [nodejs#11355](nodejs#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](nodejs@3e6f1032a4)] [nodejs#10805](nodejs#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](nodejs@5de3cf099c)] [nodejs#10116](nodejs#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](nodejs@84a23391f6)] [nodejs#12113](nodejs#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](nodejs@56e881d0b0)] [nodejs#11975](nodejs#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](nodejs@03e89b3ff2)] [nodejs#10116](nodejs#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](nodejs@dd20e68b0f)] [nodejs#12725](nodejs#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](nodejs@3f27f02da0)] [nodejs#11599](nodejs#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (nodejs@ec7cbaf266)] [nodejs#12995](nodejs#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](nodejs@a16b570f8c)] [nodejs#11968](nodejs#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](nodejs@010f864426)] [nodejs#12949](nodejs#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](nodejs@a5f91ab230)] [nodejs#11689](nodejs#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](nodejs@8a7db9d4b5)] [nodejs#12087](nodejs#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](nodejs@b6e1d22fa6)] [nodejs#12925](nodejs#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](nodejs@07c7f198db)] [nodejs#12828](nodejs#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](nodejs@348cc80a3c)] [nodejs#5923](nodejs#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](nodejs@a2ae08999b)] [nodejs#11349](nodejs#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](nodejs@d523eb9c40)] [nodejs#11447](nodejs#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](nodejs@d080ead0f9)] [nodejs#12710](nodejs#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](nodejs@5bfd13b81e)] [nodejs#9726](nodejs#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](nodejs@455e6f1dd8)] [nodejs#11708](nodejs#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](nodejs@aab0d202f8)] [nodejs#11624](nodejs#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](nodejs@99da8e8e02)] [nodejs#12442](nodejs#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](nodejs@91383e47fd)] [nodejs#12001](nodejs#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](nodejs@b514bd231e)] [nodejs#11391](nodejs#11391).

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](4a7233c178)] [#12892](#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](d2d32ea5a2)] [#11968](#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](7eb1b4658e)] [#12141](#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](beca3244e2)] [#10236](#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](97a77288ce)] [#12348](#12348), [[`d75fdd96aa`](d75fdd96aa)] [#10423](#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](627ecee9ed)] [#10653](#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](f18e08d820)] [#9744](#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](3c3b36af0f)] [#12936](#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](60d1aac8d2)] [#12784](#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](84dabe8373)] [#12489](#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](7a55e34ef4)] [#10467](#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](3c2a9361ff)] [#9683](#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](90403dd1d0)] [#11567](#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](d3480776c7)] [#11259](#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](fb71ba4921)] [#11355](#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](3e6f1032a4)] [#10805](#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](5de3cf099c)] [#10116](#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](84a23391f6)] [#12113](#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](56e881d0b0)] [#11975](#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](03e89b3ff2)] [#10116](#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](dd20e68b0f)] [#12725](#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](3f27f02da0)] [#11599](#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (ec7cbaf266)] [#12995](#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](a16b570f8c)] [#11968](#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](010f864426)] [#12949](#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](a5f91ab230)] [#11689](#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](8a7db9d4b5)] [#12087](#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](b6e1d22fa6)] [#12925](#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](07c7f198db)] [#12828](#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](348cc80a3c)] [#5923](#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](a2ae08999b)] [#11349](#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](d523eb9c40)] [#11447](#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](d080ead0f9)] [#12710](#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](5bfd13b81e)] [#9726](#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](455e6f1dd8)] [#11708](#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](aab0d202f8)] [#11624](#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](99da8e8e02)] [#12442](#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](91383e47fd)] [#12001](#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](b514bd231e)] [#11391](#11391).

damirka · 2017-06-07T09:30:34Z

lib/_stream_writable.js

+  this.finalCalled = false;
+
+  // if _final has been called
+  this.finalCalled = false;


Why did you write it twice? Hmm.

Very likely a mistake. This has already been fixed.
https://github.com/nodejs/node/blob/master/lib/_stream_writable.js#L61-L63

szmarczak · 2018-12-10T21:42:17Z

lib/_stream_writable.js

+    if (typeof stream._final === 'function') {
+      state.pendingcb++;
+      state.finalCalled = true;
+      process.nextTick(callFinal, stream, state);


Hmm... Is process.nextTick really needed here? Can someone confirm/deny?

@szmarczak This looks like a classic case where process.nextTick() is called for-- it's a case where the final function may be sync or async. This post explains more about it. https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/#process-nexttick

I know what process.nextTick does :P Well, in my case, _final() is sync and process.nextTick() is useless. I haven't checked if that's required by some other Node code, so I'm just asking :)

Okay, I found some other cases that require moving it to next tick. 👍

calvinmetcalf added the stream Issues and PRs related to the stream subsystem. label May 4, 2017

nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 4, 2017

calvinmetcalf force-pushed the streams-final branch from 4bd3978 to 4cc6fc5 Compare May 4, 2017 14:30

mscdex reviewed May 4, 2017

View reviewed changes

addaleax reviewed May 4, 2017

View reviewed changes

calvinmetcalf mentioned this pull request May 8, 2017

stream: add _end method to write streams (equivilent to _flush) #2314

Closed

addaleax approved these changes May 9, 2017

View reviewed changes

mcollina reviewed May 9, 2017

View reviewed changes

mcollina approved these changes May 9, 2017

View reviewed changes

calvinmetcalf force-pushed the streams-final branch from 5852d7e to a2c5e98 Compare May 9, 2017 17:16

jasnell approved these changes May 9, 2017

View reviewed changes

calvinmetcalf force-pushed the streams-final branch from a2c5e98 to 44aa9e8 Compare May 10, 2017 11:56

calvinmetcalf force-pushed the streams-final branch from 44aa9e8 to ac74a41 Compare May 10, 2017 12:17

jasnell reviewed May 10, 2017

View reviewed changes

calvinmetcalf force-pushed the streams-final branch from ac74a41 to 3ce4904 Compare May 10, 2017 19:42

This was referenced May 22, 2017

CITGM fail websockets/ws#1118

Closed

stream: add destroy and _destroy methods. #12925

Closed

refack approved these changes May 24, 2017

View reviewed changes

calvinmetcalf closed this May 24, 2017

calvinmetcalf mentioned this pull request May 25, 2017

stream: remove dup property #13216

Merged

jasnell mentioned this pull request May 28, 2017

8.0.0 Release Proposal #12220

Closed

mcollina mentioned this pull request Jun 6, 2017

Need a way to detect end of stream on custom Writable Streams implementing _write #2994

Closed

damirka reviewed Jun 7, 2017

View reviewed changes

MylesBorins mentioned this pull request Jan 15, 2018

Semver Minor Tracking nodejs/Release#298

Closed

szmarczak reviewed Dec 10, 2018

View reviewed changes

stream: add final method #12828

stream: add final method #12828

Conversation

calvinmetcalf commented May 4, 2017 • edited Loading

Checklist

Affected core subsystem(s)

vsemozhetbyt commented May 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vsemozhetbyt May 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mscdex commented May 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mscdex May 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addaleax commented May 4, 2017

calvinmetcalf commented May 5, 2017

calvinmetcalf commented May 9, 2017

addaleax commented May 9, 2017

addaleax left a comment

Choose a reason for hiding this comment

addaleax May 9, 2017 • edited Loading

Choose a reason for hiding this comment

calvinmetcalf commented May 9, 2017

addaleax commented May 9, 2017

calvinmetcalf commented May 9, 2017

addaleax commented May 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

calvinmetcalf commented May 9, 2017

jasnell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcollina commented May 9, 2017

calvinmetcalf commented May 10, 2017

calvinmetcalf commented May 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lpinca commented May 22, 2017

refack commented May 22, 2017 • edited Loading

refack commented May 22, 2017

calvinmetcalf commented May 24, 2017

mcollina commented May 24, 2017

refack left a comment

Choose a reason for hiding this comment

calvinmetcalf commented May 24, 2017

marshall007 commented May 25, 2017

mcollina commented May 25, 2017

calvinmetcalf commented May 25, 2017

Choose a reason for hiding this comment

mcollina Jun 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

calvinmetcalf commented May 4, 2017 •

edited

Loading

vsemozhetbyt May 4, 2017 •

edited

Loading

mscdex May 5, 2017 •

edited

Loading

addaleax May 9, 2017 •

edited

Loading

refack commented May 22, 2017 •

edited

Loading

mcollina Jun 7, 2017 •

edited

Loading