src: don't lazy-load timer globals #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Don't lazy-load setInterval(), setTimeout(), etc. Most applications are going to need them and routing every call through NativeModule.require() and Function#apply() is not exactly efficient. PR-URL: nodejs#1280 Reviewed-By: Jeremiah Senkpiel <[email protected]>
bnoordhuis
force-pushed
the
dont-lazy-load-timer-globals
branch
from
c10f243 to
2903410
Compare
just a side note: this was using |
|
Sure, but it's still less efficient than calling the function directly. |
|
What about lazy-loading the functions only on first call ? global.setTimeout = function() {
var t = NativeModule.require('timers');
global.setTimeout = t.setTimeout;
return t.setTimeout.apply(this, arguments);
}; |
|
What good would that do? This PR is based off the observation that the timers module is almost certainly going to get loaded anyway (by core, if not the user) so you might as well do it eagerly. |
Qard
added a commit
to Qard/async-listener
that referenced
this pull request
Apr 7, 2015
Timer functions are now mounted directly on global as of iojs 1.6.3 See: nodejs/node#1280
Qard
added a commit
to othiym23/async-listener
that referenced
this pull request
Apr 8, 2015
Timer functions are now mounted directly on global as of iojs 1.6.3 See: nodejs/node#1280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't lazy-load setInterval(), setTimeout(), etc. Most applications are
going to need them and routing every call through NativeModule.require()
and Function#apply() is not exactly efficient.
R=@trevnorris?
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/382/