doc: fix examples in repl.md #12684
Closed
doc: fix examples in repl.md #12684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update an example according to an actual REPL session. * Replace an arrow function with a common function to hold `this`.
nodejs-github-bot
added
doc
lpinca
approved these changes
Apr 27, 2017
cjihrig
approved these changes
Apr 27, 2017
jasnell
approved these changes
Apr 27, 2017
|
Landed in 8092fb0 |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 28, 2017
* Update an example according to an actual REPL session. * Replace an arrow function with a common function to hold `this`. PR-URL: #12684 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
* Update an example according to an actual REPL session. * Replace an arrow function with a common function to hold `this`. PR-URL: #12684 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
* Update an example according to an actual REPL session. * Replace an arrow function with a common function to hold `this`. PR-URL: #12684 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
* Update an example according to an actual REPL session. * Replace an arrow function with a common function to hold `this`. PR-URL: #12684 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 3, 2017
* Update an example according to an actual REPL session. * Replace an arrow function with a common function to hold `this`. PR-URL: #12684 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
So it seems like we don't have a note that the example found at https://github.com/nodejs/node/blob/8092fb0a59927159ec68c914771c6be484116203/doc/api/repl.md#replserverdefinecommandkeyword-cmd should not be run in the repl. Should we open an issue about this? Good first PR 😄 |
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
|
It seems this PR can be ignored in v6: its doc has not changes that had made those examples erroneous, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, repl
this.