deps: update node-inspect to v1.11.2

[jkrems]

This updates the bundled node-inspect to 1.11.2, including nodejs/node-inspect#43 which was previously cherry-picked in #11441.

Highlights

• Support for debugging a pid (node inspect -p <pid>)
• Fixes to support latest master changes
• Memory & CPU profiling added to help text

Compare: nodejs/node-inspect@v1.10.6...v1.11.2

Rendered Changelog

1.11.2

• 42e0cd1 fix: look for generic hint text

1.11.1

• Prefer --inspect-brk over --debug-brk - @ofrobots #43
  • 2c1ed27 fix: use --inspect-brk with Node 8+

1.11.0

• doc: add profile and heap to help - @joshgav #39
  • f64c920 doc: add profile and heap to help
• Update test suite to pass on latest nightly - @jkrems #36
  • 41148d7 test: Remove outdated test
  • 2c224c5 test: Accept any kind of "break"
  • 22bf349 test: Adjust for v8 5.7
  • 6ce8c16 test: Revert to old assertions
• Verify custom port support - @jkrems #41
  • e3a489f test: custom port
• Support for debugging a pid - @jkrems #37
  • 4179506 feat: Support for debugging a pid

Checklist

• make -j4 test and make test-node-inspect pass
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

deps

[jkrems]

Example for debugging a pid:

1. Start the debug target and retrieve its pid:

   $ ./node -e 'setInterval(() => { debugger; console.log("ok"); }, 5000); console.log(process.pid)'
   <pid>
   ok
   

2. Attach the CLI debugger to the process in a separate shell session:

   $ ./node inspect -p <pid>
   break in [eval]:1
   > 1 setInterval(() => { debugger; console.log("ok"); }, 5000); console.log(process.pid)
   

[aqrln]

LGTM, thanks!

Oh, and this PR reminded me that I was interested in writing some tests and improving autocompletion of object properties, so thank you for this incidental reminder too 😄

[Trott]

Rubber-stamp LGTM if all tests pass in CI

[aqrln]

CI: https://ci.nodejs.org/job/node-test-pull-request/7360/

[jkrems]

freebsd failure:

not ok 728 parallel/test-net-connect-local-error
  ---
  duration_ms: 0.193
  severity: fail
  stack: |-
    
    assert.js:82
      throw new assert.AssertionError({
      ^
    AssertionError: undefined !== 12346 in Error: connect EADDRINUSE 127.0.0.1:12347 - Local (127.0.0.1:12346)
        at Socket.onError (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-net-connect-local-error.js:13:10)
        at Socket.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/common.js:461:15)
        at emitOne (events.js:115:13)
        at Socket.emit (events.js:210:7)
        at emitErrorNT (net.js:1305:8)
        at _combinedTickCallback (internal/process/next_tick.js:80:11)
        at process._tickCallback (internal/process/next_tick.js:104:9)
  ...

[Trott]

@jkrems My current guess as to what happened here: parallel/test-net-connect-options-allowhalfopen started running slightly before parallel/test-net-connect-local-error (but finished slightly after as it took almost 200ms longer to run) and it's server.listen(0, ...) happened to get assigned port 12346, conflicting with the use of common.PORT in parallel/test-net-connect-local-error.

So, in brief, unrelated to this change (which shouldn't be a surprise, I suppose).

I'll re-run CI and I'll also see about perhaps moving all use of common.PORT into sequential or else adjusting the tests to use port 0. (I think someone--@mscdex or @cjihrig, maybe?--already went through and made as many tests as could be trivially made to use port 0 do so, but I'll look anyway, just in case I'm misremembering.)

CI: https://ci.nodejs.org/job/node-test-pull-request/7365/

[Trott]

New CI is green, woot.

[mscdex]

@Trott Yep, AFAIK the remaining tests still using common.PORT are cluster-related tests because of an outstanding issue with assigning random ports for cluster workers.

[jkrems]

@Trott Thanks for looking into this! I assumed it was something along those lines but didn't have time yet to take a look myself.

[joshgav]

@jkrems can we pull in nodejs/node-inspect#44 too? Thanks!

[jkrems]

@joshgav Done!

[addaleax]

New CI: https://ci.nodejs.org/job/node-test-commit/9117/

[addaleax]

Landed in 0217197

[gibfahn]

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.