doc: add history of options param being added to fs.readdir()
#12312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
reviewed
Apr 10, 2017
doc/api/fs.md
Outdated
| @@ -1442,6 +1442,9 @@ changes: | |||
| pr-url: https://github.com/nodejs/node/pull/7897 | |||
| description: The `callback` parameter is no longer optional. Not passing | |||
| it will emit a deprecation warning. | |||
| - version: v6.0.0 | |||
| pr-url: https://github.com/nodejs/node/pull/5616 | |||
| description: The `options` parameter was added | |||
addaleax
approved these changes
Apr 10, 2017
cjihrig
approved these changes
Apr 10, 2017
vsemozhetbyt
approved these changes
Apr 10, 2017
sam-github
approved these changes
Apr 10, 2017
shubheksha
changed the title
options param being added to fs.readdir()
aqrln
approved these changes
Apr 10, 2017
There was a problem hiding this comment.
LGTM, but the first line of the commit message should not exceed 50 characters and the "Fixes: #12299" metadata field should be added to the commit message. How about something like this?
doc: add missing changelog entry for fs.readdir()
Document that the `options` parameter of `fs.readdir()` was added
in Node.js 6.0.0.
Fixes: https://github.com/nodejs/node/issues/12299
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. Fixes: #12299
|
@aqrln, done! |
jasnell
approved these changes
Apr 11, 2017
|
Landed in 4ac3ef5. Thanks! |
aqrln
pushed a commit
that referenced
this pull request
Apr 12, 2017
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: #12312 Fixes: #12299 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: #12312 Fixes: #12299 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: #12312 Fixes: #12299 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
Document that the `options` parameter of `fs.readdir()` was added in Node.js 6.0.0. PR-URL: #12312 Fixes: #12299 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Fixes #12299