Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for url #11999

Closed
wants to merge 1 commit into from
Closed

test: add test for url #11999

wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Mar 23, 2017

Added one test case.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 23, 2017
@hiroppy hiroppy added the url Issues and PRs related to the legacy built-in url module. label Mar 23, 2017
@hiroppy
Copy link
Member Author

hiroppy commented Mar 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6991/

@hiroppy
Copy link
Member Author

hiroppy commented Mar 24, 2017

Landed in abb0bdd

hiroppy added a commit that referenced this pull request Mar 24, 2017
@hiroppy
test: add test for url
abb0bdd 
PR-URL: #11999
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
@hiroppy hiroppy closed this Mar 24, 2017
@hiroppy hiroppy deleted the feature/add-url-test branch March 24, 2017 16:00
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@hiroppy @MylesBorins
test: add test for url
764a00e 
PR-URL: #11999
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@princejwesley princejwesley princejwesley approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hiroppy @jasnell @princejwesley @joyeecheung @MylesBorins @nodejs-github-bot