Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add regex to assert in test_cyclic_link_protection #11498

Closed
wants to merge 6 commits into from
Closed

test: add regex to assert in test_cyclic_link_protection #11498

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d062327
test: add regex to match error message
clarenced Feb 19, 2017
38ad8d7
test: lint error correction
clarenced Feb 22, 2017
3dd9731
test: add regex to match error message
clarenced Feb 19, 2017
77fb1b3
test: lint error correction
clarenced Feb 22, 2017
4370eb5
test: test assertions improvements
clarenced Feb 25, 2017
1130abd
test: update the call of the function common.expectsError
clarenced Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions test/parallel/test-fs-realpath.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,15 @@ function test_cyclic_link_protection(callback) {
fs.symlinkSync(t[1], t[0], 'dir');
unlink.push(t[0]);
});
assert.throws(function() { fs.realpathSync(entry); });
asynctest(fs.realpath, [entry], callback, function(err, result) {
assert.ok(err && true);
return true;
});
assert.throws(() => {
fs.realpathSync(entry);
}, common.expectsError({ code: 'ELOOP', type: Error }));
asynctest(
fs.realpath, [entry], callback, common.mustCall(function(err, result) {
assert.ok(err.path === entry);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use assert.strictEqual() here and in the line below:

assert.strictEqual(err.path, entry);
assert.strictEqual(result, undefined);

That will provide better error messages should the assertion fire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott Hi, I have made the modification as requested in another branch called test_11498. #11622

assert.ok(result === undefined);
return true;
}));
}

function test_cyclic_link_overprotection(callback) {
Expand Down