doc,test: args to buffer.copy can be Uint8Arrays
#11486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
buffer
jasnell
approved these changes
Feb 22, 2017
lpinca
reviewed
Feb 22, 2017
test/parallel/test-buffer-copy.js
Outdated
| } | ||
| } | ||
|
|
||
| // Test that the source can be a Uint8Array, doo. |
There was a problem hiding this comment.
@lpinca lol yes, thanks for pointing out. done! 😄
This was semi-overlooked in nodejs#10236 because it always worked and didn’t need additional changes. Ref: nodejs#10236
addaleax
force-pushed
the
buf-copy-uint8array
branch
from
2851c32 to
6e49735
Compare
lpinca
approved these changes
Feb 22, 2017
|
Landed in cba1020 |
addaleax
added a commit
that referenced
this pull request
Feb 24, 2017
This was semi-overlooked in #10236 because it always worked and didn’t need additional changes. Ref: #10236 PR-URL: #11486 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 24, 2017
This was semi-overlooked in #10236 because it always worked and didn’t need additional changes. Ref: #10236 PR-URL: #11486 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
|
This will need a backport PR to land in v4.x |
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
This was semi-overlooked in #10236 because it always worked and didn’t need additional changes. Ref: #10236 PR-URL: #11486 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
This was semi-overlooked in #10236 because it always worked and didn’t need additional changes. Ref: #10236 PR-URL: #11486 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was semi-overlooked in #10236 because it always worked and didn’t need additional changes.
Ref: #10236
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
buffer
CI: https://ci.nodejs.org/job/node-test-commit/8059/