-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer: removing duplicate code #1144
Conversation
- using an overload of Alloc that does the same that was being done inside `Buffer::New` The overload we now call inside `smalloc.cc` takes care of the same as the code that was removed: ```cc if (length == 0) return Alloc(env, obj, nullptr, length, type); char* data = static_cast<char*>(malloc(length)); if (data == nullptr) { FatalError("node::smalloc::Alloc(v8::Handle<v8::Object>, size_t," " v8::ExternalArrayType)", "Out Of Memory"); } Alloc(env, obj, data, length, type); ```
@bnoordhuis I think this is cruft and can be removed. See something I might be missing? |
CI is failing due to github problems :( |
There are two CI runs in progress at the moment, it's possible this one got queued. @rvagg? |
I fixed the queueing recently so that no build slave could have two jobs on it simultaneously which should solve older queuing problems we were having but Jenkins is kind of terrible at managing its git clones so things get messed up a bit sometimes. Submitted again @ https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/300/ so let's see .. |
None of those look to be failing because of this PR. |
What's the status on this? CI looks ok. |
- using an overload of Alloc that does the same that was being done inside `Buffer::New` The overload we now call inside `smalloc.cc` takes care of the same as the code that was removed: if (length == 0) return Alloc(env, obj, nullptr, length, type); char* data = static_cast<char*>(malloc(length)); if (data == nullptr) { FatalError("node::smalloc::Alloc(v8::Handle<v8::Object>, size_t," " v8::ExternalArrayType)", "Out Of Memory"); } Alloc(env, obj, data, length, type); PR-URL: #1144 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
Thanks Thorsten, landed in 813a536. |
inside
Buffer::New
The overload we now call inside
smalloc.cc
takes care of the same asthe code that was removed:
/cc @trevnorris