http: deprecate Agent.prototype.addRequest() legacy sig #11353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy signature of Agent.prototype.addRequest() was replaced four years ago. This emits a runtime deprecation if the legacy signature is used. A potentially deoptimizing use of arguments is also fixed. Ref: nodejs@12cd133
jasnell
added
the
semver-major
|
@addaleax and @evanlucas ... I take it by the frowny faces you'd rather this not happen? :-) Given that no one else has chimed in I'm inclined to close without further action |
|
@jasnell This seems like something that comes with minimal maintenance cost, so I am very okay with not deprecating it. |
|
Yep, understood. Didn't really feel strongly about it just doing routine maintenance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy signature of Agent.prototype.addRequest() was replaced
four years ago. This emits a runtime deprecation if the legacy
signature is used.
A potentially deoptimizing use of arguments is also fixed.
Ref: 12cd133
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http