internal/util: use internal/errors.js #11301

seppevs · 2017-02-10T20:26:27Z

Change internal/util.js so it makes use of the new internal/errors.js module.

See #11273 for more info.

cc @jasnell

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

error

joyeecheung · 2017-02-11T10:34:33Z

test/parallel/test-internal-errors.js

+assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE', ['a', ['b', 'c']]),
+                   'The "a" argument must be one of type b, or c');
+assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE',
+                   ['a', ['b', 'c', 'd']]),


nit: indentation looks off here?

joyeecheung · 2017-02-11T10:34:41Z

test/parallel/test-internal-errors.js

+assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE', ['a', 'b', 'c']),
+                   'The "a" argument must be type b. Received type string');
+assert.strictEqual(errors.message('ERR_INVALID_ARG_TYPE',
+                   ['a', 'b', undefined]),


@joyeecheung: the indentation is suggested by the linter

Hmm, looks like the linter is OK with arguments not indented the same way, as long as it's indented? Anyway it doesn't need to be fixed, just a nit :D

No, the linter expects the identation to start at an exact position: the position where the parameters start on the previous line.

thefourtheye · 2017-02-12T17:45:01Z

lib/internal/errors.js

 // Add new errors from here...
+


I think this function should go to the top.

I used @jasnell 's PR as an example: #11300

joyeecheung · 2017-02-15T16:18:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/6427/

jasnell · 2017-05-01T19:16:25Z

We're finally able to move forward on this, but it's going to need a rebase

seppevs · 2017-05-01T20:12:45Z

Rebase done

joyeecheung · 2017-05-02T15:23:24Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/7802/

jasnell · 2017-05-02T21:55:38Z

@nodejs/ctc ... this is ready to go, but as a semver-major needs another CTC member to sign off

Trott

LGTM modulo textual nits and assuming CI is green.

Trott · 2017-05-02T23:34:09Z

doc/api/errors.md

+
+An error using the `'ERR_NO_CRYPTO'` error code is thrown specifically when 
+an attempt is made to use crypto features while Node.js is not compiled 
+with OpenSSL crypto support


Nit: Please put a period at the end of the sentence.

Trott · 2017-05-02T23:34:42Z

lib/internal/errors.js

@@ -111,6 +111,7 @@ E('ERR_IPC_DISCONNECTED', 'IPC channel is already disconnected');
 E('ERR_IPC_ONE_PIPE', 'Child process can have only one IPC pipe');
 E('ERR_IPC_SYNC_FORK', 'IPC cannot be used with synchronous forks');
 E('ERR_MISSING_ARGS', missingArgs);
+E('ERR_NO_CRYPTO', 'Node.js is not compiled with openssl crypto support');


Nit: openssl -> OpenSSL

seppevs · 2017-05-03T06:55:03Z

Changes done

fhinkel · 2017-05-23T18:36:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/8257/

Trott · 2017-05-24T05:06:28Z

@jasnell Should the blocked label be removed?

jasnell · 2017-05-24T10:32:20Z

test/parallel/test-internal-util-assertCrypto.js

 const assert = require('assert');
 const util = require('internal/util');

+const expectedError = common.expectsError('ERR_NO_CRYPTO', Error);


this should use the object param... e.g.

common.expectsError({ code: 'ERR_NO_CRYPTO', type: Error });

tniessen · 2017-06-14T17:42:06Z

@seppevs Please fix @jasnell's annotation (#11301 (comment)) and resolve the conflicts.

tniessen · 2017-06-14T17:45:54Z

doc/api/errors.md

+<a id="ERR_NO_CRYPTO"></a>
+### ERR_NO_CRYPTO
+
+An error using the `'ERR_NO_CRYPTO'` error code is thrown specifically when 


Please adapt this to match the wording used in #13627 ("Used when an attempt is made...").

seppevs · 2017-06-15T12:59:02Z

Changes done

tniessen · 2017-06-15T13:09:18Z

doc/api/errors.md

+<a id="ERR_NO_CRYPTO"></a>
+### ERR_NO_CRYPTO
+
+Used when an attempt is made to use crypto features while Node.js is not compiled


Nit: This should be wrapped at 80 characters. I will approve and start CI after this is fixed.

tniessen · 2017-06-15T14:03:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/8677/

tniessen · 2017-06-15T15:10:13Z

Landed in de4a749, thank you! 🎉

PR-URL: #11301 Refs: #11273 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. util Issues and PRs related to the built-in util module. labels Feb 10, 2017

jasnell approved these changes Feb 10, 2017

View reviewed changes

jasnell mentioned this pull request Feb 10, 2017

Tracking Issue: Migrate errors to internal/errors.js #11273

Closed

80 tasks

seppevs force-pushed the internal_util_use_internal_errors branch from 42ca4c3 to 0cb54ec Compare February 10, 2017 21:12

joyeecheung reviewed Feb 11, 2017

View reviewed changes

thefourtheye reviewed Feb 12, 2017

View reviewed changes

joyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 14, 2017

jasnell added the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2017

refack force-pushed the master branch from 16073c0 to fbe946b Compare April 14, 2017 04:11

seppevs force-pushed the internal_util_use_internal_errors branch from 0cb54ec to 70f3091 Compare May 1, 2017 20:12

Trott approved these changes May 2, 2017

View reviewed changes

seppevs force-pushed the internal_util_use_internal_errors branch from 70f3091 to 498b4b3 Compare May 3, 2017 06:55

fhinkel approved these changes May 23, 2017

View reviewed changes

joyeecheung approved these changes May 24, 2017

View reviewed changes

jasnell removed the blocked PRs that are blocked by other issues or PRs. label May 24, 2017

jasnell reviewed May 24, 2017

View reviewed changes

tniessen requested changes Jun 14, 2017

View reviewed changes

seppevs force-pushed the internal_util_use_internal_errors branch from 498b4b3 to 812fb50 Compare June 15, 2017 12:59

tniessen reviewed Jun 15, 2017

View reviewed changes

internal/util: use internal/errors.js

efddcf1

seppevs force-pushed the internal_util_use_internal_errors branch from 812fb50 to efddcf1 Compare June 15, 2017 13:16

hiroppy approved these changes Jun 15, 2017

View reviewed changes

tniessen approved these changes Jun 15, 2017

View reviewed changes

tniessen self-assigned this Jun 15, 2017

tniessen closed this Jun 15, 2017

jasnell mentioned this pull request Oct 30, 2017

Proposal: 2017-10-31, Version 9.0.0 (Current) #15135

Merged

bradennapier mentioned this pull request Nov 3, 2017

[REQUEST]: Document Breaking Changes in 9.0 #16713

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

internal/util: use internal/errors.js #11301

internal/util: use internal/errors.js #11301

seppevs commented Feb 10, 2017

joyeecheung Feb 11, 2017

joyeecheung Feb 11, 2017

seppevs Feb 11, 2017

joyeecheung Feb 12, 2017

seppevs Feb 13, 2017

thefourtheye Feb 12, 2017

seppevs Feb 13, 2017

joyeecheung commented Feb 15, 2017

jasnell commented May 1, 2017

seppevs commented May 1, 2017

joyeecheung commented May 2, 2017

jasnell commented May 2, 2017

Trott left a comment

Trott May 2, 2017

Trott May 2, 2017

seppevs commented May 3, 2017

fhinkel commented May 23, 2017

Trott commented May 24, 2017

jasnell May 24, 2017

tniessen commented Jun 14, 2017 •

edited

Loading

tniessen Jun 14, 2017

seppevs commented Jun 15, 2017

tniessen Jun 15, 2017 •

edited

Loading

seppevs Jun 15, 2017

tniessen commented Jun 15, 2017

tniessen commented Jun 15, 2017

internal/util: use internal/errors.js #11301

internal/util: use internal/errors.js #11301

Conversation

seppevs commented Feb 10, 2017

Checklist

Affected core subsystem(s)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joyeecheung commented Feb 15, 2017

jasnell commented May 1, 2017

seppevs commented May 1, 2017

joyeecheung commented May 2, 2017

jasnell commented May 2, 2017

Trott left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seppevs commented May 3, 2017

fhinkel commented May 23, 2017

Trott commented May 24, 2017

Choose a reason for hiding this comment

tniessen commented Jun 14, 2017 • edited Loading

Choose a reason for hiding this comment

seppevs commented Jun 15, 2017

tniessen Jun 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tniessen commented Jun 15, 2017

tniessen commented Jun 15, 2017

tniessen commented Jun 14, 2017 •

edited

Loading

tniessen Jun 15, 2017 •

edited

Loading