errors: assign error code to bootstrap_node created error #11298

jasnell · 2017-02-10T18:26:16Z

This does not use the internal/errors.js module because the error in question may actually be caused by an attempt to load internal/errors.js. This error should only be encountered in the case of a bug within Node.js itself.

Ref: #11273

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

errors, src

Fishrock123 · 2017-02-10T18:31:14Z

This is perhaps misleading as these are not necessarily "native" as in "C/C++" modules.

jasnell · 2017-02-10T18:32:50Z

Yep. It certainly is. Basing this off the existing wording (I did not change the error message at all). Do you have a suggestion for an alternative?

joyeecheung · 2017-02-10T18:50:01Z

doc/api/errors.md

@@ -563,6 +563,17 @@ found [here][online].
  encountered by [`http`][] or [`net`][] -- often a sign that a `socket.end()`
  was not properly called.

+<a id="nodejs-error-codes">
+## Node.js Error Codes
+


We probably need a section explaining the new error system(like the section on "system errors" above mentioning those would have error.code, error. errno and error. syscall properties, then list the error codes). Going straight to error code descriptions seems pretty confusing if people read it from the top to the bottom...

Yep, I agree. I was thinking of doing that in a separate PR

joyeecheung · 2017-02-11T10:38:41Z

@jasnell @Fishrock123 do we have a name for the lib modules in general?

joyeecheung · 2017-02-11T10:39:52Z

LGTM with the naming sorted out

jasnell · 2017-02-11T16:43:43Z

@joyeecheung ... not really with regards to naming. Perhaps built-in or internal would work?

joyeecheung · 2017-02-12T06:38:54Z

Sorry, I wasn't being clear. I meant I am fine with native as long as we have a decision native is the word we use for lib modules, whichever we use we should stick to that :D

I do think built-in would be more unambiguous though. For contributors internal sounds like lib/internal modules, but if I understand correctly this covers unknown lib modules.

thefourtheye · 2017-02-12T17:47:01Z

doc/api/errors.md

@@ -563,6 +563,17 @@ found [here][online].
  encountered by [`http`][] or [`net`][] -- often a sign that a `socket.end()`
  was not properly called.

+<a id="nodejs-error-codes">


Why don't we let the tools to generate the id for all these? It would be consistent that way.

Because these anchors need to be consistent and predictable even if the structure of the document changes. Doing it this way ensures that the anchors will not change.

joyeecheung · 2017-02-14T13:21:10Z

lib/internal/errors.js

@@ -85,4 +85,5 @@ module.exports = exports = {
 //
 // Note: Please try to keep these in alphabetical order
 E('ERR_ASSERTION', (msg) => msg);
+E('ERR_UNKNOWN_NATIVE_MODULE', (id) => `No such built-in module: ${id}`);


Now that the error message is updated to No such built-in module, the error code should be changed accordingly?

jasnell · 2017-02-14T16:13:12Z

Updated. PTAL

jasnell · 2017-03-22T21:32:37Z

Ping @nodejs/ctc ... can I get a review on this?

jasnell · 2017-03-22T21:33:13Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/6983/

mhdawson

LGTM

jasnell · 2017-04-20T19:06:39Z

This is no longer blocked. PR updated.
@targos @mhdawson @joyeecheung ... PTAL, does this still LGTY?

Fishrock123 · 2017-04-20T20:00:36Z

I think this is a misnomer, IIRC that module does not need to be built-in to possibly hit this path? (Don't all native modules hit this or something?)

Note: I understand it is called "NativeModule as in "builtin natives".

jasnell · 2017-04-20T23:04:44Z

Not that I'm aware of. In every condition that I was able to find, most users will only see the "Cannot find module" error. This appears to be hit only in very specific cases involving the built-in modules. I could be wrong, but that's what I've been able to see. There's aren't even any test cases that I can see that trigger/test this.

joyeecheung · 2017-04-21T06:06:04Z

@jasnell FWIW, I have only ever hit this path when I accidentally deleted a js file from node.gyp...

thefourtheye · 2017-04-21T14:41:01Z

lib/internal/bootstrap_node.js

+      // Model the error off the internal/errors.js model, but
+      // do not use that module given that it could actually be
+      // the one causing the error if there's a bug in Node.js
+      const err = new Error(`No such built-in module ${id}`);


Nit: There is a colon in errors.js file

jasnell · 2017-04-21T17:07:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7571/

jasnell · 2017-04-21T17:41:31Z

@Fishrock123 ... are you satisfied with this?

targos

LGTM with a nit

targos · 2017-04-24T14:32:39Z

lib/internal/bootstrap_node.js

+      // the one causing the error if there's a bug in Node.js
+      const err = new Error(`No such built-in module: ${id}`);
+      err.code = 'ERR_UNKNOWN_BUILTIN_MODULE';
+      err.name = 'Error[ERR_UNKNOWN_BUILTIN_MODULE]';


nit: there should be a space now that 7b4a72d has landed.

This does not use the internal/errors.js module because the error in question may actually be *caused* by an attempt to load internal/errors.js. This error should only be encountered in the case of a bug within Node.js itself. Ref: nodejs#11273

This does not use the internal/errors.js module because the error in question may actually be *caused* by an attempt to load internal/errors.js. This error should only be encountered in the case of a bug within Node.js itself. PR-URL: #11298 Ref: #11273 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

jasnell · 2017-04-24T16:16:02Z

Landed in 251e5ed

Fishrock123 · 2017-04-24T18:17:22Z

Hmm, ok sounds good to me. Belated LGTM.

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 10, 2017

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 10, 2017

jasnell mentioned this pull request Feb 10, 2017

Tracking Issue: Migrate errors to internal/errors.js #11273

Closed

80 tasks

joyeecheung reviewed Feb 10, 2017

View reviewed changes

joyeecheung approved these changes Feb 11, 2017

View reviewed changes

thefourtheye reviewed Feb 12, 2017

View reviewed changes

joyeecheung reviewed Feb 14, 2017

View reviewed changes

jasnell force-pushed the internal-errors-2 branch from dcdda51 to 40637de Compare February 14, 2017 16:12

joyeecheung approved these changes Feb 14, 2017

View reviewed changes

joyeecheung mentioned this pull request Feb 14, 2017

errors, process: port internal/process errors to internal/errors #11294

Closed

4 tasks

jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Feb 14, 2017

jasnell force-pushed the internal-errors-2 branch from 40637de to 7a94c93 Compare March 22, 2017 21:29

jasnell added the ctc-review label Mar 22, 2017

targos approved these changes Mar 23, 2017

View reviewed changes

Trott mentioned this pull request Mar 26, 2017

Node.js Foundation Core Technical Committee (CTC) Meeting 2017-03-29 nodejs/CTC#85

Closed

Trott mentioned this pull request Apr 3, 2017

Node.js Foundation Core Technical Committee (CTC) Meeting 2017-04-05 nodejs/CTC#93

Closed

mhdawson approved these changes Apr 5, 2017

View reviewed changes

jasnell added the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2017

Trott mentioned this pull request Apr 9, 2017

Node.js Foundation Core Technical Committee (CTC) Meeting 2017-04-12 nodejs/CTC#98

Closed

refack force-pushed the master branch from 16073c0 to fbe946b Compare April 14, 2017 04:11

Trott mentioned this pull request Apr 17, 2017

Node.js Foundation Core Technical Committee (CTC) Meeting 2017-04-19 nodejs/CTC#105

Closed

jasnell force-pushed the internal-errors-2 branch from 7a94c93 to 7707ed9 Compare April 20, 2017 19:05

jasnell removed the blocked PRs that are blocked by other issues or PRs. label Apr 20, 2017

joyeecheung approved these changes Apr 21, 2017

View reviewed changes

thefourtheye approved these changes Apr 21, 2017

View reviewed changes

jasnell force-pushed the internal-errors-2 branch from 7707ed9 to 491185c Compare April 21, 2017 17:04

Trott mentioned this pull request Apr 24, 2017

Node.js Foundation Core Technical Committee (CTC) Meeting 2017-04-26 nodejs/CTC#111

Closed

targos approved these changes Apr 24, 2017

View reviewed changes

jasnell force-pushed the internal-errors-2 branch from 491185c to de5c440 Compare April 24, 2017 16:05

jasnell closed this Apr 24, 2017

Trott removed the ctc-review label May 1, 2017

jasnell mentioned this pull request May 11, 2017

8.0.0 Release Proposal #12220

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

errors: assign error code to bootstrap_node created error #11298

errors: assign error code to bootstrap_node created error #11298

jasnell commented Feb 10, 2017

Fishrock123 commented Feb 10, 2017

jasnell commented Feb 10, 2017

joyeecheung Feb 10, 2017 •

edited

Loading

jasnell Feb 10, 2017

joyeecheung commented Feb 11, 2017

joyeecheung commented Feb 11, 2017

jasnell commented Feb 11, 2017

joyeecheung commented Feb 12, 2017

thefourtheye Feb 12, 2017

jasnell Feb 13, 2017

joyeecheung Feb 14, 2017

jasnell commented Feb 14, 2017

jasnell commented Mar 22, 2017

jasnell commented Mar 22, 2017

mhdawson left a comment

jasnell commented Apr 20, 2017

Fishrock123 commented Apr 20, 2017 •

edited

Loading

jasnell commented Apr 20, 2017

joyeecheung commented Apr 21, 2017

thefourtheye Apr 21, 2017

jasnell commented Apr 21, 2017

jasnell commented Apr 21, 2017

targos left a comment

targos Apr 24, 2017

jasnell commented Apr 24, 2017

Fishrock123 commented Apr 24, 2017

errors: assign error code to bootstrap_node created error #11298

errors: assign error code to bootstrap_node created error #11298

Conversation

jasnell commented Feb 10, 2017

Checklist

Affected core subsystem(s)

Fishrock123 commented Feb 10, 2017

jasnell commented Feb 10, 2017

joyeecheung Feb 10, 2017 • edited Loading

Choose a reason for hiding this comment

jasnell Feb 10, 2017

Choose a reason for hiding this comment

joyeecheung commented Feb 11, 2017

joyeecheung commented Feb 11, 2017

jasnell commented Feb 11, 2017

joyeecheung commented Feb 12, 2017

thefourtheye Feb 12, 2017

Choose a reason for hiding this comment

jasnell Feb 13, 2017

Choose a reason for hiding this comment

joyeecheung Feb 14, 2017

Choose a reason for hiding this comment

jasnell commented Feb 14, 2017

jasnell commented Mar 22, 2017

jasnell commented Mar 22, 2017

mhdawson left a comment

Choose a reason for hiding this comment

jasnell commented Apr 20, 2017

Fishrock123 commented Apr 20, 2017 • edited Loading

jasnell commented Apr 20, 2017

joyeecheung commented Apr 21, 2017

thefourtheye Apr 21, 2017

Choose a reason for hiding this comment

jasnell commented Apr 21, 2017

jasnell commented Apr 21, 2017

targos left a comment

Choose a reason for hiding this comment

targos Apr 24, 2017

Choose a reason for hiding this comment

jasnell commented Apr 24, 2017

Fishrock123 commented Apr 24, 2017

joyeecheung Feb 10, 2017 •

edited

Loading

Fishrock123 commented Apr 20, 2017 •

edited

Loading