-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add coverage for string array dgram send() #11247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm curious: do we / should we test arrays of other data types also?
Yea, that code is already covered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: nodejs#11247 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
bf1121b
to
df14956
Compare
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: #11247 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: nodejs#11247 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: nodejs#11247 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: #11247 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit adds code coverage for dgram's Socket#send() where the data is an array of strings. PR-URL: #11247 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit adds code coverage for
dgram
'sSocket#send()
where the data is an array of strings.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test