Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lookup.h #10937

Closed
wants to merge 1 commit into from
Closed

Update lookup.h #10937

wants to merge 1 commit into from

Conversation

jiakai1000
Copy link

@jiakai1000 jiakai1000 commented Jan 21, 2017 •
edited by joyeecheung
Loading

fix compile error

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@jiakai1000
Update lookup.h
d9b0ba0 
fix compile error
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jan 21, 2017
@addaleax addaleax added duplicate Issues and PRs that are duplicates of other issues or PRs. v6.x labels Jan 21, 2017
@addaleax
Copy link
Member

Hi, thanks for the PR! Unfortunately (or luckily?), this has already been fixed in #10525, which will be included in the next v6.x release.

So, yea, sit tight, wait for that, and everything will be fine. :) I’m closing this as a duplicate but feel free to ask any follow-up questions you may have!

@addaleax addaleax closed this Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiakai1000 @addaleax @nodejs-github-bot