-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: make request.abort()
destroy the socket
#10818
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const http = require('http'); | ||
|
||
let socketsCreated = 0; | ||
|
||
class Agent extends http.Agent { | ||
createConnection(options, oncreate) { | ||
const socket = super.createConnection(options, oncreate); | ||
socketsCreated++; | ||
return socket; | ||
} | ||
} | ||
|
||
const server = http.createServer((req, res) => res.end()); | ||
|
||
server.listen(0, common.mustCall(() => { | ||
const port = server.address().port; | ||
const agent = new Agent({ | ||
keepAlive: true, | ||
maxSockets: 1 | ||
}); | ||
|
||
http.get({agent, port}, (res) => res.resume()); | ||
|
||
const req = http.get({agent, port}, common.fail); | ||
req.abort(); | ||
|
||
http.get({agent, port}, common.mustCall((res) => { | ||
res.resume(); | ||
assert.strictEqual(socketsCreated, 1); | ||
agent.destroy(); | ||
server.close(); | ||
})); | ||
})); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const http = require('http'); | ||
const net = require('net'); | ||
|
||
const server = http.createServer(common.fail); | ||
|
||
server.listen(0, common.mustCall(() => { | ||
const req = http.get({ | ||
createConnection(options, oncreate) { | ||
const socket = net.createConnection(options, oncreate); | ||
socket.once('close', () => server.close()); | ||
return socket; | ||
}, | ||
port: server.address().port | ||
}); | ||
|
||
req.abort(); | ||
})); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const http = require('http'); | ||
|
||
const server = http.createServer(common.fail); | ||
|
||
class Agent extends http.Agent { | ||
createConnection(options, oncreate) { | ||
const socket = super.createConnection(options, oncreate); | ||
socket.once('close', () => server.close()); | ||
return socket; | ||
} | ||
} | ||
|
||
common.refreshTmpDir(); | ||
|
||
server.listen(common.PIPE, common.mustCall(() => { | ||
const req = http.get({ | ||
agent: new Agent(), | ||
socketPath: common.PIPE | ||
}); | ||
|
||
req.abort(); | ||
})); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not even sure if it's appropriate to emit 'free' and skip destroying the socket.
ClientRequest#abort()
always callssocket.destroy()
when there is one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnoordhuis I think this is for keep-alive sockets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnoordhuis I guess you were referring to
node/lib/_http_client.js
Lines 296 to 299 in 77be180
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is when
socket.emit('free');
was added: d0c7d93#diff-e3bc37430eb078ccbafe3aa3b570c91a, previously the socket was destroyed in all cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should always
destroy()
, I do not see a way for this socket to be reused even if there is an agent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. There's really no safe way to reuse it.
destroy()
is the safest thing to doThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a test which should clarify why
socket.emit('free')
is used. It's for queued requests which are already aborted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See f52c874b737ccb7e92d640b31e02c6efb3acd22c.