Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-stream-transform-object #10588

Closed
wants to merge 1 commit into from
Closed

test: refactor test-stream-transform-object #10588

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 3, 2017

  • use common.mustCall() as appropriate
  • eliminate exit handler
  • var -> const/let
  • provide duration for setInterval()
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test stream

@Trott Trott added stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. labels Jan 3, 2017
thefourtheye
thefourtheye reviewed Jan 3, 2017
View reviewed changes
test/parallel/test-stream-transform-objectmode-falsey-value.js
var i = -1;
var int = setInterval(function() {
let i = -1;
const int = setInterval(function() {
if (i > 10) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this hardcoded number also be replaced with expect.length?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have to be something odd like expect.length - 2 or expect[expect.length -1] or something like that. I'm not opposed but not exactly in favor either.

test/parallel/test-stream-transform-objectmode-falsey-value.js
var i = -1;
var int = setInterval(function() {
let i = -1;
const int = setInterval(function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might look like overkill, but how about mustCalling this function as well?

@Trott
test: refactor test-stream-transform-object
f95716a 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()
@Trott
Copy link
Member Author

Trott commented Jan 6, 2017

@thefourtheye Nits addressed, I think. PTAL.

@Trott
Copy link
Member Author

Trott commented Jan 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5714/

Trott added a commit to Trott/io.js that referenced this pull request Jan 6, 2017
@Trott
test: refactor test-stream-transform-object
f43ea2a 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: nodejs#10588
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jan 6, 2017

Landed in f43ea2a

@Trott Trott closed this Jan 6, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@Trott @italoacasas
test: refactor test-stream-transform-object
9afd752 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: nodejs#10588
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@Trott @italoacasas
test: refactor test-stream-transform-object
ef4c9ce 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: nodejs#10588
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 26, 2017
@Trott @italoacasas
test: refactor test-stream-transform-object
74e3eff 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: nodejs#10588
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@Trott @italoacasas
test: refactor test-stream-transform-object
67246ba 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: nodejs#10588
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@Trott @italoacasas
test: refactor test-stream-transform-object
55377db 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: nodejs#10588
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@Trott @italoacasas
test: refactor test-stream-transform-object
2daa5aa 
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: nodejs#10588
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

@Trott Trott deleted the transform branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@italoacasas italoacasas italoacasas approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @MylesBorins @jasnell @thefourtheye @italoacasas @gibfahn @mscdex @nodejs-github-bot