test: refactor test and add common.mustCall #10017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
code-and-learn
cjihrig
requested changes
Dec 5, 2016
| var common = require('../common'); | ||
| var assert = require('assert'); | ||
| const common = require('../common'); | ||
| const assert = require('assert'); |
There was a problem hiding this comment.
This line can be moved below the common.hasCrypto check.
| var dir = common.fixturesDir; | ||
| var options = { key: fs.readFileSync(dir + '/test_key.pem'), | ||
| const dir = common.fixturesDir; | ||
| const options = { key: fs.readFileSync(dir + '/test_key.pem'), | ||
| cert: fs.readFileSync(dir + '/test_cert.pem'), |
There was a problem hiding this comment.
I think these lines should be indented now.
|
|
||
| var server = tls.createServer(options, function(c) { | ||
| const server = tls.createServer(options, common.mustCall(function(c) { |
There was a problem hiding this comment.
The common.mustCall() here seems unnecessary.
|
|
||
| process.on('exit', function() { | ||
|
|
There was a problem hiding this comment.
Please remove the unnecessary added blank lines.
|
Ping @bchirgwin: Are you able to update this based on the comments from @cjihrig? |
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual()
|
@cjihrig I updated this per your comments and pushed to @bchirgwin's branch. Can you please take a look and, if appropriate, update your review? Thanks! |
cjihrig
approved these changes
Dec 24, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 24, 2016
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: nodejs#10017 Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 6281a1c. |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: #10017 Reviewed-By: Colin Ihrig <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: #10017 Reviewed-By: Colin Ihrig <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: #10017 Reviewed-By: Colin Ihrig <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: #10017 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: #10017 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: #10017 Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
var -> let / const added common.mustCall() to callback assert.equal() -> assert.strictEqual() PR-URL: #10017 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
var -> let / const
added common.mustCall to callbacks