test: update to const and strictEqual #10007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subsystem name should be all lowercase. |
Update `var` to `const` and `assert.equal` to `assert.strictEqual`
imyller
added
the
code-and-learn
ghvaldez
force-pushed
the
update-test-parallel-priv-port
branch
from
4d6b946 to
facf714
Compare
|
commit message updated. subsystem is now in all lowercase. |
ghvaldez
changed the title
cjihrig
approved these changes
Dec 3, 2016
|
This is my first change...did this during code & learn NINA 2016 .... do I merge myself or will someone merge this? |
|
@ghvaldez We will do that, it just takes us a while to et everyone’s PRs reviewed and ready for merging :) |
|
CI failure is unrelated. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2016
Update `var` to `const` PR-URL: nodejs#10007 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in cc4e5e1 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Update `var` to `const` PR-URL: #10007 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Update `var` to `const` PR-URL: nodejs#10007 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Update `var` to `const` PR-URL: nodejs#10007 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Update `var` to `const` PR-URL: #10007 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Update `var` to `const` PR-URL: #10007 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Update `var` to `const` PR-URL: #10007 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Updated all var to const and updated assert.equal to
assert.strictEqual