FreeBSD failures on v4.x

[MylesBorins]

This is a very odd one parallel/test-child-process-uid-gid started failing today when I was testing v4.x.

This test has not failed in the past, but is now failing the current head of v4.x-staging, v4.6.0, and v4.5.0

I am unsure if this is an env issue or not... I have attempted to ssh into one of our BSD machines, manually compile and test, and see no failures.

I've also attempted to manually in the artifact directory that jenkins used both with the commands

$ ./node test/parallel/test-child-process-uid-gid.js

and

$ python tools/test.py parallel/test-child-process-uid-gid

neither of these attempts fail either.

[MylesBorins]

/cc @nodejs/platform-freebsd

[indutny]

Logs?

[MylesBorins]

https://ci.nodejs.org/job/node-test-commit-freebsd/4728/nodes=freebsd10-64/tapTestReport/test.tap-81/

not ok 81 parallel/test-child-process-uid-gid
# 
# assert.js:89
# throw new assert.AssertionError({
# ^
# AssertionError: Missing expected exception..
# at _throws (assert.js:337:5)
# at Function.assert.throws (assert.js:361:3)
# at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-child-process-uid-gid.js:8:8)
# at Module._compile (module.js:409:26)
# at Object.Module._extensions..js (module.js:416:10)
# at Module.load (module.js:343:32)
# at Function.Module._load (module.js:300:12)
# at Function.Module.runMain (module.js:441:10)
# at startup (node.js:139:18)
# at node.js:974:3

[indutny]

Thanks!

[indutny]

That's:

spawn('echo', ['fhqwhgads'], {uid: 0})

That is expected to throw EPERM.

[MylesBorins]

the error is that it isn't throwing
¯_(ツ)_/¯

[indutny]

@thealphanerd oh, I was just stating what happens in test. Sorry!

[indutny]

@thealphanerd is it running under root (or superuser)? Is it running in jail?

[indutny]

@thealphanerd what is the output of sysctl security.bsd.suser_enabled?

[MylesBorins]

when I was manually running it security.bsd.suser_enabled: 1

@jbergstroem may know more about how things are setup during CI

[indutny]

@jbergstroem I wonder if this box may be running tests with effective user id set to 0?

[indutny]

@thealphanerd thanks!

[indutny]

@jbergstroem further question, do we use https://www.freebsd.org/doc/handbook/mac.html ?

[jbergstroem]

@indutny no, we run as regular user:

$ id
uid=1002(iojs) gid=1002(iojs) groups=1002(iojs)

re mac: this is stock freebsd 10.3p9 -- I recall mac modules being optional so I'd say no.

[targos]

@MylesBorins is this fixed?

[MylesBorins]

yup