Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ClangCL compilation time on Windows. #55208

Closed
StefanStojanovic opened this issue Oct 1, 2024 · 1 comment · Fixed by #55249
Closed

Improve ClangCL compilation time on Windows. #55208

StefanStojanovic opened this issue Oct 1, 2024 · 1 comment · Fixed by #55249
Assignees
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@StefanStojanovic
Copy link
Contributor

StefanStojanovic commented Oct 1, 2024

Version

main branch

Platform

Windows

Subsystem

build

What steps will reproduce the bug?

Compiling Node.js with ClangCL eg. running vcbuild.bat clang-cl.

How often does it reproduce? Is there a required condition?

Always.

What is the expected behavior? Why is that the expected behavior?

I expect small, subtle differences between MSVC and ClangCL compilation time.

What do you see instead?

ClangCL compilation is ~2.5 slower (less with x64, more with ARM64).

Additional information

The main difference is that ClangCL doesn't use precompiled headers, which MSVC does. There might be others too.

Refs: #52809

@StefanStojanovic StefanStojanovic added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Oct 1, 2024
@StefanStojanovic StefanStojanovic self-assigned this Oct 2, 2024
@StefanStojanovic
Copy link
Contributor Author

Forgot to self-assign yesterday. I'm working on it and should have a PR for it this week.

StefanStojanovic added a commit to JaneaSystems/node that referenced this issue Oct 3, 2024
nodejs-github-bot pushed a commit that referenced this issue Oct 11, 2024
Fixes: #55208
PR-URL: #55249
Reviewed-By: Yagiz Nizipli <[email protected]>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
ruyadorno pushed a commit that referenced this issue Nov 27, 2024
Fixes: #55208
PR-URL: #55249
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant