Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky: benchmark/test-benchmark-crypto #52690

Open
mhdawson opened this issue Apr 25, 2024 · 2 comments
Open

flaky: benchmark/test-benchmark-crypto #52690

mhdawson opened this issue Apr 25, 2024 · 2 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform.

Comments

@mhdawson
Copy link
Member

Test

test-benchmark-crypto

Platform

Linux x64

Console output

11:19:53 not ok 4009 benchmark/test-benchmark-crypto
11:19:53   ---
11:19:53   duration_ms: 3234.66800
11:19:53   severity: fail
11:19:53   exitcode: 1
11:19:53   stack: |-
11:19:53     node:assert:126
11:19:53       throw new AssertionError(obj);
11:19:53       ^
11:19:53     
11:19:53     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
11:19:53     
11:19:53     1 !== 0
11:19:53     
11:19:53         at main (/home/iojs/build/workspace/node-test-commit-linux/benchmark/crypto/timingSafeEqual.js:21:10)
11:19:53         at /home/iojs/build/workspace/node-test-commit-linux/benchmark/common.js:54:9
11:19:53         at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
11:19:53       generatedMessage: true,
11:19:53       code: 'ERR_ASSERTION',
11:19:53       actual: 1,
11:19:53       expected: 0,
11:19:53       operator: 'strictEqual'
11:19:53     }
11:19:53     
11:19:53     Node.js v22.0.0-pre
11:19:53     node:assert:126
11:19:53       throw new AssertionError(obj);
11:19:53       ^
11:19:53     
11:19:53     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
11:19:53     
11:19:53     1 !== 0
11:19:53     
11:19:53         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/common/benchmark.js:28:12)
11:19:53         at ChildProcess.emit (node:events:520:28)
11:19:53         at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
11:19:53       generatedMessage: true,
11:19:53       code: 'ERR_ASSERTION',
11:19:53       actual: 1,
11:19:53       expected: 0,
11:19:53       operator: 'strictEqual'
11:19:53     }
11:19:53     
11:19:53     Node.js v22.0.0-pre

Build links

Additional information

No response

@mhdawson mhdawson added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Apr 25, 2024
@github-actions github-actions bot added the linux Issues and PRs related to the Linux platform. label Apr 25, 2024
@richardlau
Copy link
Member

Given this stack trace

11:19:53         at main (/home/iojs/build/workspace/node-test-commit-linux/benchmark/crypto/timingSafeEqual.js:21:10)

this is most likely going to be for the same reason as #38226.

@jakecastelli
Copy link
Member

jakecastelli commented Jun 14, 2024

Flaky again here in this PR

see Detail
not ok 4016 benchmark/test-benchmark-crypto
19:42:55   ---
19:42:55   duration_ms: 2513.95400
19:42:55   severity: fail
19:42:55   exitcode: 1
19:42:55   stack: |-
19:42:55     node:assert:126
19:42:55       throw new AssertionError(obj);
19:42:55       ^
19:42:55     
19:42:55     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
19:42:55     
19:42:55     1 !== 0
19:42:55     
19:42:55         at main (/home/iojs/build/workspace/node-test-commit-linux-containered/benchmark/crypto/timingSafeEqual.js:21:10)
19:42:55         at /home/iojs/build/workspace/node-test-commit-linux-containered/benchmark/common.js:54:9
19:42:55         at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
19:42:55       generatedMessage: true,
19:42:55       code: 'ERR_ASSERTION',
19:42:55       actual: 1,
19:42:55       expected: 0,
19:42:55       operator: 'strictEqual'
19:42:55     }
19:42:55     
19:42:55     Node.js v23.0.0-pre
19:42:55     node:assert:126
19:42:55       throw new AssertionError(obj);
19:42:55       ^
19:42:55     
19:42:55     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
19:42:55     
19:42:55     1 !== 0
19:42:55     
19:42:55         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/benchmark.js:28:12)
19:42:55         at ChildProcess.emit (node:events:520:28)
19:42:55         at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
19:42:55       generatedMessage: true,
19:42:55       code: 'ERR_ASSERTION',
19:42:55       actual: 1,
19:42:55       expected: 0,
19:42:55       operator: 'strictEqual'
19:42:55     }

jasnell pushed a commit that referenced this issue Jun 30, 2024
PR-URL: #52955
Refs: #52690
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this issue Jul 1, 2024
PR-URL: #52955
Refs: #52690
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
PR-URL: #52955
Refs: #52690
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
PR-URL: #52955
Refs: #52690
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform.
Projects
None yet
Development

No branches or pull requests

3 participants