Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace foreach with for in test-https-simple.js #50818

Closed
Shikha2410 opened this issue Nov 20, 2023 · 0 comments · Fixed by #49793
Closed

test: replace foreach with for in test-https-simple.js #50818

Shikha2410 opened this issue Nov 20, 2023 · 0 comments · Fixed by #49793
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.

Comments

@Shikha2410
Copy link

Fixing issue from GHC Open Source Day backlog
Shikha2410 pushed a commit to Shikha2410/node that referenced this issue Nov 20, 2023
test: replace foreach with for in test-https-simple.js
cc7938d 
Fixes: nodejs#50818
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 20, 2023
@nodejs-github-bot nodejs-github-bot mentioned this issue Nov 21, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Nov 23, 2023
test: replace foreach with for in test-https-simple.js
4e713a3 
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this issue Nov 26, 2023
@martenrichter
test: replace foreach with for in test-https-simple.js
b5ca578 
Fixes: nodejs#50818
PR-URL: nodejs#49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this issue Nov 27, 2023
test: replace foreach with for in test-https-simple.js
4a3ce61 
Fixes: nodejs#50818
PR-URL: nodejs#49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 27, 2023
@RafaelGSS
test: replace foreach with for in test-https-simple.js
b851895 
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 29, 2023
@RafaelGSS
test: replace foreach with for in test-https-simple.js
9d76de1 
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 30, 2023
@RafaelGSS
test: replace foreach with for in test-https-simple.js
76bd704 
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
UlisesGascon pushed a commit that referenced this issue Dec 11, 2023
@UlisesGascon
test: replace foreach with for in test-https-simple.js
6a64824 
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
UlisesGascon pushed a commit that referenced this issue Dec 13, 2023
@UlisesGascon
test: replace foreach with for in test-https-simple.js
622cf68 
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
UlisesGascon pushed a commit that referenced this issue Dec 15, 2023
@UlisesGascon
test: replace foreach with for in test-https-simple.js
347e92a 
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
UlisesGascon pushed a commit that referenced this issue Dec 19, 2023
@UlisesGascon
test: replace foreach with for in test-https-simple.js
107b5e6 
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: replace foreach with for in test-https-simple.js Shikha2410/node
2 participants
@tniessen @Shikha2410