Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8 CI is broken #48728

Closed
richardlau opened this issue Jul 10, 2023 · 2 comments · Fixed by #48729
Closed

V8 CI is broken #48728

richardlau opened this issue Jul 10, 2023 · 2 comments · Fixed by #48729
Labels
v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Comments

@richardlau
Copy link
Member

V8 CI is broken (looks like we're still trying to run it with Python 2.7)

Originally posted by @targos in #48710 (comment)
@richardlau
Copy link
Member Author

Seems to have started failing last Friday
e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/5432/
https://ci.nodejs.org/job/node-test-commit-v8-linux/5432/nodes=rhel8-s390x,v8test=v8test/console

10:34:50 + ../../tools/v8/fetch_deps.py .
10:34:50 Cloning into '/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools'...
10:34:53   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient.py", line 3461
10:34:53     f'160000,{value},{name}'
10:34:53                            ^
10:34:53 SyntaxError: invalid syntax
10:34:53 Checking out depot_tools.
10:34:53 Traceback (most recent call last):
10:34:53   File "../../tools/v8/fetch_deps.py", line 100, in <module>
10:34:53     FetchDeps(sys.argv[1])
10:34:53   File "../../tools/v8/fetch_deps.py", line 72, in FetchDeps
10:34:53     depot_tools = node_common.EnsureDepotTools(v8_path, True)
10:34:53   File "/home/iojs/build/workspace/node-test-commit-v8-linux/tools/v8/node_common.py", line 40, in EnsureDepotTools
10:34:53     depot_tools = _Get(v8_path)
10:34:53   File "/home/iojs/build/workspace/node-test-commit-v8-linux/tools/v8/node_common.py", line 37, in _Get
10:34:53     cwd=depot_tools)
10:34:53   File "/usr/lib64/python2.7/subprocess.py", line 223, in check_output
10:34:53     raise CalledProcessError(retcode, cmd, output=output)
10:34:53 subprocess.CalledProcessError: Command '['/usr/bin/python', '/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient.py', 'metrics', '--opt-out']' returned non-zero exit status 1
10:34:53 make: *** [Makefile:303: v8] Error 1

It's a bit of a surprise that we are still running fetch_deps.py with Python 2. I'll open a PR to update.

This was referenced Jul 10, 2023
Merged
Merged
@richardlau
Copy link
Member Author

Opened #48729.
Also needs some updates on the build infrastructure (already applied): nodejs/build#3418

@richardlau richardlau added v16.x v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jul 10, 2023
nodejs-github-bot pushed a commit that referenced this issue Jul 12, 2023
@richardlau
tools: run fetch_deps.py with Python 3
6a1316d 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@richardlau richardlau mentioned this issue Jul 12, 2023
Merged
juanarbol pushed a commit that referenced this issue Jul 13, 2023
@richardlau @juanarbol
tools: run fetch_deps.py with Python 3
4398ade 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
richardlau added a commit to nodejs/build that referenced this issue Jul 15, 2023
@richardlau
ansible: install V8 build deps for Python 3 (#3418)
e32c159 
Ensure `httplib2` and `six` modules are installed for Python 3 on
machines with the `build-test-v8` role.

Refs: nodejs/node#48728
Refs: nodejs/node#48710 (comment)
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@richardlau @Ceres6
tools: run fetch_deps.py with Python 3
27123de 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: nodejs#48729
Fixes: nodejs#48728
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@richardlau @Ceres6
tools: run fetch_deps.py with Python 3
ae4e31e 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: nodejs#48729
Fixes: nodejs#48728
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
richardlau added a commit to richardlau/node-1 that referenced this issue Aug 24, 2023
@richardlau
tools: run fetch_deps.py with Python 3
a578e6d 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: nodejs#48729
Fixes: nodejs#48728
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this issue Sep 12, 2023
@richardlau @ruyadorno
tools: run fetch_deps.py with Python 3
ab2a804 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this issue Sep 13, 2023
@richardlau @ruyadorno
tools: run fetch_deps.py with Python 3
98663a9 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this issue Sep 17, 2023
@richardlau @ruyadorno
tools: run fetch_deps.py with Python 3
4826379 
Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
which spawns `glient`, with Python 3.

PR-URL: #48729
Fixes: #48728
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: run fetch_deps.py with Python 3 richardlau/node-1
1 participant
@richardlau