Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: wrong return type of describe #48571

Closed
shockerqt opened this issue Jun 27, 2023 · 0 comments · Fixed by #48572
Closed

doc: wrong return type of describe #48571

shockerqt opened this issue Jun 27, 2023 · 0 comments · Fixed by #48572
Labels
doc Issues and PRs related to the documentations.

Comments

@shockerqt
Copy link
Contributor

Affected URL(s)

https://nodejs.org/api/test.html#describename-options-fn

Description of the problem

The documentation says that describe return undefined but it actually returns a Promise just like test.
@shockerqt shockerqt added the doc Issues and PRs related to the documentations. label Jun 27, 2023
@shrujalshah28 shrujalshah28 mentioned this issue Jun 27, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Jun 29, 2023
@shrujalshah28
doc: update return type for describe
fe4ac37 
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this issue Jul 3, 2023
@shrujalshah28 @RafaelGSS
doc: update return type for describe
cc3a056 
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@shrujalshah28 @Ceres6
doc: update return type for describe
4b340f5 
PR-URL: nodejs#48572
Fixes: nodejs#48571
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@shrujalshah28 @Ceres6
doc: update return type for describe
dcbc22a 
PR-URL: nodejs#48572
Fixes: nodejs#48571
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
ruyadorno pushed a commit that referenced this issue Sep 11, 2023
@shrujalshah28 @ruyadorno
doc: update return type for describe
2884705 
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
ruyadorno pushed a commit that referenced this issue Sep 13, 2023
@shrujalshah28 @ruyadorno
doc: update return type for describe
f436ac1 
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: update return type for describe shrujalshah28/node
1 participant
@shockerqt