Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky InspectorSocketTest.HostIPv6NonRoutable #47427

Closed
mhdawson opened this issue Apr 5, 2023 · 1 comment · Fixed by #53400
Closed

flaky InspectorSocketTest.HostIPv6NonRoutable #47427

mhdawson opened this issue Apr 5, 2023 · 1 comment · Fixed by #53400
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@mhdawson
Copy link
Member

mhdawson commented Apr 5, 2023

Test

InspectorSocketTest.HostIPv6NonRoutable

Platform

Other

Console output

../test/cctest/test_inspector_socket.cc:323
Value of: (!expectation.read_expected)
  Actual: true
Expected: false
Stacktrace
../test/cctest/test_inspector_socket.cc:323
Value of: (!expectation.read_expected)
  Actual: true
Expected: false

Build links

Additional information

No response
@mhdawson mhdawson added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Apr 5, 2023
@mhdawson
Copy link
Member Author

again - https://ci.nodejs.org/job/node-test-binary-windows-native-suites/21855/

@huseyinacacak-janea huseyinacacak-janea mentioned this issue Jun 10, 2024
Merged
@targos targos mentioned this issue Jun 11, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Jun 12, 2024
@huseyinacacak-janea
src: fix IsIPAddress for IPv6
73fa9ab 
Fix the bug when copying IPv6 host to a variable to remove brackets.

Fixes: #47427
PR-URL: #53400
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this issue Jun 20, 2024
@huseyinacacak-janea @targos
src: fix IsIPAddress for IPv6
4704270 
Fix the bug when copying IPv6 host to a variable to remove brackets.

Fixes: #47427
PR-URL: #53400
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this issue Jun 20, 2024
@huseyinacacak-janea @eliphazbouye
src: fix IsIPAddress for IPv6
05bb310 
Fix the bug when copying IPv6 host to a variable to remove brackets.

Fixes: nodejs#47427
PR-URL: nodejs#53400
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@huseyinacacak-janea @bmeck
src: fix IsIPAddress for IPv6
37cb863 
Fix the bug when copying IPv6 host to a variable to remove brackets.

Fixes: nodejs#47427
PR-URL: nodejs#53400
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
@huseyinacacak-janea @marco-ippolito
src: fix IsIPAddress for IPv6
517c263 
Fix the bug when copying IPv6 host to a variable to remove brackets.

Fixes: #47427
PR-URL: #53400
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
@huseyinacacak-janea @marco-ippolito
src: fix IsIPAddress for IPv6
f773b28 
Fix the bug when copying IPv6 host to a variable to remove brackets.

Fixes: #47427
PR-URL: #53400
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: fix IsIPAddress for IPv6 JaneaSystems/node
1 participant
@mhdawson