-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Documentation - Change style of parameter type #4350
Comments
/cc @nodejs/documentation |
To clarify, this is actually a css issue - specifically in https://github.com/nodejs/node/blob/master/doc/api_assets/style.css#L351 - no idea what the best way to style it is, though. |
Better yet, make those types links to either MDN documentation for Numbers, Objects, etc, and Nodejs documentation for Handle Objects, Streams, etc. |
👍 |
That is possible to do in the markdown-to-html doc tool. I'll work on a PR |
Changes the parsing of parameter types, links to MDN or nodejs docs. See nodejs#4350 example: "* {Object}" -> "* <link to MDN><Object></link>"
Changes the parsing of parameter types in the doc html gen Links to either MDN or nodejs docs depending on type See nodejs#4350
Changes the parsing of parameter types in the doc html gen Links to either MDN or nodejs docs depending on type See #4350 PR-URL: #4741 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Changes the parsing of parameter types in the doc html gen Links to either MDN or nodejs docs depending on type See #4350 PR-URL: #4741 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Changes the parsing of parameter types in the doc html gen Links to either MDN or nodejs docs depending on type See #4350 PR-URL: #4741 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Changes the parsing of parameter types in the doc html gen Links to either MDN or nodejs docs depending on type See #4350 PR-URL: #4741 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Changes the parsing of parameter types in the doc html gen Links to either MDN or nodejs docs depending on type See #4350 PR-URL: #4741 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Fixes: #4350 PR-URL: #6016 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fixes: #4350 PR-URL: #6016 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fixes: #4350 PR-URL: #6016 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fixes: #4350 PR-URL: #6016 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This is just a minor one. Yet, it's confusing when reading:
In the docs the parameter description style doesn't distinguish between the parameter's type and the actual description. There is not even a punctuation character separating these two (see image below).
I suggest to use a distinct style for a parameter's type.
The text was updated successfully, but these errors were encountered: