Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.7 Regression on url.resolve breaks Yarn 1.x #42279

Closed
arcanis opened this issue Mar 10, 2022 · 0 comments · Fixed by #42280
Closed

17.7 Regression on url.resolve breaks Yarn 1.x #42279

arcanis opened this issue Mar 10, 2022 · 0 comments · Fixed by #42280
Labels
url Issues and PRs related to the legacy built-in url module.

Comments

@arcanis
Copy link
Contributor

arcanis commented Mar 10, 2022

Version

17.7

Platform

n/a

Subsystem

n/a

What steps will reproduce the bug?

yarn init
yarn add @zkochan/cmd-shim

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Should work as in 17.6

What do you see instead?

info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...

Additional information

Caused by #42136. This diff seems to break Yarn Classic, which does:

url.resolve('https://registry.npmjs.org', '@foo/bar')

Node 17.6: https://registry.npmjs.org/@foo/bar
Node 17.7: https://foo/bar

aduh95 added a commit to aduh95/node that referenced this issue Mar 10, 2022
@meixg meixg added the url Issues and PRs related to the legacy built-in url module. label Mar 10, 2022
sxa pushed a commit to sxa/node that referenced this issue Mar 10, 2022
Trott added a commit to Trott/io.js that referenced this issue Mar 10, 2022
Trott pushed a commit to Trott/io.js that referenced this issue Mar 10, 2022
Trott added a commit to Trott/io.js that referenced this issue Mar 10, 2022
Trott added a commit to Trott/io.js that referenced this issue Mar 10, 2022
nodejs-github-bot pushed a commit that referenced this issue Mar 10, 2022
This reverts commit 010cb71.

Refs: #42279

PR-URL: #42280
Fixes: #42279
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Trott added a commit to Trott/io.js that referenced this issue Mar 10, 2022
sxa pushed a commit that referenced this issue Mar 10, 2022
This reverts commit 010cb71.

Refs: #42279

PR-URL: #42280
Fixes: #42279
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
nodejs-github-bot pushed a commit that referenced this issue Mar 11, 2022
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
simao-silva added a commit to simao-silva/docker-renovate that referenced this issue Mar 11, 2022
Node version 17.6.0 had a continuous error message "info There appears to be trouble with your network connection. Retrying..." corrected by nodejs/node#42279 with the release of version 17.6.1.
bengl pushed a commit that referenced this issue Mar 21, 2022
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
Refs: nodejs#42279

PR-URL: nodejs#42283
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
This reverts commit 010cb71.

Refs: nodejs#42279

PR-URL: nodejs#42280
Fixes: nodejs#42279
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
Refs: nodejs#42279

PR-URL: nodejs#42283
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants