Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emojis not rendered in new issue template selection #41987

Closed
targos opened this issue Feb 15, 2022 · 3 comments · Fixed by #41989
Closed

Emojis not rendered in new issue template selection #41987

targos opened this issue Feb 15, 2022 · 3 comments · Fixed by #41989
Labels
meta Issues and PRs related to the general management of the project.

Comments

@targos
Copy link
Member

targos commented Feb 15, 2022

I don't know if it's a GitHub bug or recent change, but some emojis are not rendered:

image
@targos targos assigned targos and unassigned targos Feb 15, 2022
@targos targos added the meta Issues and PRs related to the general management of the project. label Feb 15, 2022
@aduh95
Copy link
Contributor

aduh95 commented Feb 15, 2022

Maybe related to the changes in #41756?

@Mesteery
Copy link
Contributor

Yes, it's related. I opened a discussion on github/feedback: community/community#11540.

@targos
Copy link
Member Author

targos commented Feb 15, 2022

Do we actually need an escape sequence? Why don't we put the character directly inline?

Mesteery added a commit to Mesteery/node that referenced this issue Feb 15, 2022
@Mesteery
meta: use plain emojis instead of escape sequences
e7ebd2a 
Refs: nodejs#41987
@Mesteery Mesteery mentioned this issue Feb 15, 2022
Merged
@targos targos linked a pull request Feb 15, 2022 that will close this issue
meta: use plain emojis instead of escape sequences #41989
Merged
nodejs-github-bot pushed a commit that referenced this issue Feb 17, 2022
@Mesteery
meta: use plain emojis instead of escape sequences
4829f85 
Refs: #41987

PR-URL: #41989
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bengl pushed a commit to bengl/node that referenced this issue Feb 21, 2022
@Mesteery @bengl
meta: use plain emojis instead of escape sequences
12269f7 
Refs: nodejs#41987

PR-URL: nodejs#41989
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bengl pushed a commit to bengl/node that referenced this issue Feb 21, 2022
@Mesteery @bengl
meta: use plain emojis instead of escape sequences
50d3550 
Refs: nodejs#41987

PR-URL: nodejs#41989
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bengl pushed a commit that referenced this issue Feb 21, 2022
@Mesteery @bengl
meta: use plain emojis instead of escape sequences
ed9624b 
Refs: #41987

PR-URL: #41989
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bengl pushed a commit that referenced this issue Feb 21, 2022
@Mesteery @bengl
meta: use plain emojis instead of escape sequences
224745c 
Refs: #41987

PR-URL: #41989
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bengl pushed a commit that referenced this issue Feb 22, 2022
@Mesteery @bengl
meta: use plain emojis instead of escape sequences
f51b55d 
Refs: #41987

PR-URL: #41989
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
@Mesteery @danielleadams
meta: use plain emojis instead of escape sequences
131ecec 
Refs: nodejs#41987

PR-URL: nodejs#41989
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
@Mesteery @danielleadams
meta: use plain emojis instead of escape sequences
f5ffa34 
Refs: #41987

PR-URL: #41989
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

meta: use plain emojis instead of escape sequences Mesteery/node
3 participants
@targos @aduh95 @Mesteery