Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured cloning implementation from performance.mark is incomplete #40840

Closed
zloirock opened this issue Nov 17, 2021 · 1 comment · Fixed by #40904
Closed

Structured cloning implementation from performance.mark is incomplete #40840

zloirock opened this issue Nov 17, 2021 · 1 comment · Fixed by #40904
Labels
perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Comments

@zloirock
Copy link

zloirock commented Nov 17, 2021 •
edited
Loading

Version

17.1.0

Platform

MacOS 12

Subsystem

No response

What steps will reproduce the bug?

performance.mark(1, { detail: /q/i }).detail; // => Uncaught Error: Unable to deserialize cloned data

performance.mark(1, { detail: Object('a') }).detail; // => Uncaught Error: Unable to deserialize cloned data

However, structuredClone works fine here:

structuredClone(/q/i); // => /q/i

structuredClone(Object('a')); // => Object('a')

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

https://html.spec.whatwg.org/multipage/structured-data.html#structuredserializeinternal

https://html.spec.whatwg.org/multipage/structured-data.html#structureddeserialize

What do you see instead?

No response

Additional information

No response
targos added a commit to targos/node that referenced this issue Nov 21, 2021
@targos
perf_hooks: use spec-compliant structuredClone
efbe1df 
Serialize PerformanceMark's `detail` correctly.

Fixes: nodejs#40840
@targos targos mentioned this issue Nov 21, 2021
Merged
@targos
Copy link
Member

targos commented Nov 21, 2021

Fix in #40904

@Mesteery Mesteery added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Nov 21, 2021
nodejs-github-bot pushed a commit that referenced this issue Nov 29, 2021
@targos
perf_hooks: use spec-compliant structuredClone
42c0b2a 
Serialize PerformanceMark's `detail` correctly.

Fixes: #40840

PR-URL: #40904
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this issue Dec 13, 2021
@targos @danielleadams
perf_hooks: use spec-compliant structuredClone
e4b1754 
Serialize PerformanceMark's `detail` correctly.

Fixes: #40840

PR-URL: #40904
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this issue Dec 14, 2021
@targos @danielleadams
perf_hooks: use spec-compliant structuredClone
93ea166 
Serialize PerformanceMark's `detail` correctly.

Fixes: #40840

PR-URL: #40904
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf_hooks: use spec-compliant structuredClone targos/node
4 participants
@zloirock @targos @DerekNonGeneric @Mesteery