Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Missing instance method for fs.createWriteStream() #38606

Closed
1 task done
ghost opened this issue May 8, 2021 · 0 comments
Closed
1 task done

doc: Missing instance method for fs.createWriteStream() #38606

ghost opened this issue May 8, 2021 · 0 comments
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors.

Comments

@ghost
Copy link

ghost commented May 8, 2021

📗 API Reference Docs Problem

  • Version: ✍️ 14.16.1
  • Platform: ✍️Darwin omers-mbp 20.4.0 Darwin Kernel Version 20.4.0: Thu Apr 22 21:46:47 PDT 2021; root:xnu-7195.101.2~1/RELEASE_X86_64 x86_64
  • Subsystem: ✍️ File System

Location

Section of the site where the content exists

Affected URL(s):

Description

Concise explanation of the problem

The fs.WriteStream class instance of which is created by calling fs.createWriteStream has an instance method close, but it is not documented.

✍️

  • I would like to work on this issue and
    submit a pull request.
@ghost ghost added the doc Issues and PRs related to the documentations. label May 8, 2021
@aduh95 aduh95 added confirmed-bug Issues with confirmed bugs. fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors. and removed confirmed-bug Issues with confirmed bugs. labels May 9, 2021
ihiteshsharma added a commit to ihiteshsharma/node that referenced this issue May 9, 2021
@ihiteshsharma
Fixes: nodejs#38606
ed2438c
@ghost ghost closed this as completed May 10, 2021
@ghost ghost reopened this May 10, 2021
@aduh95 aduh95 mentioned this issue May 11, 2021
Closed
targos pushed a commit that referenced this issue May 18, 2021
@ihiteshsharma @targos
doc: add documentation for fs.WriteStream.close()
0100a3b 
PR-URL: #38610
Fixes: #38606
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this issue Sep 4, 2021
@ihiteshsharma @targos
doc: add documentation for fs.WriteStream.close()
a44219d 
PR-URL: #38610
Fixes: #38606
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: https://github.com/nodejs/node/issues/38606 ihiteshsharma/node
1 participant
@aduh95