We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto.scrypt
Setup a node instance,
» node
and run the following javascript code.
crypto = require('crypto');crypto.scrypt('','',2147485780,(err,derivedKey)=>{});
Then the node instance occurs an abort.
This abort can always be triggered following the steps above.
If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.
» node Welcome to Node.js v16.0.0-pre. Type ".help" for more information. > crypto = require('crypto');crypto.scrypt('','',2147485780,(err,derivedKey)=>{}); /home/zys/Toolchains/node/node[209342]: ../src/crypto/crypto_scrypt.cc:90:static v8::Maybe<bool> node::crypto::ScryptTraits::AdditionalConfig(node::crypto::CryptoJobMode, const v8::FunctionCallbackInfo<v8::Value>&, unsigned int, node::crypto::ScryptConfig*): Assertion `args[offset + 6]->IsInt32()' failed. 1: 0x562ea70e1af4 node::Abort() [/home/zys/Toolchains/node/node] 2: 0x562ea70e1b88 [/home/zys/Toolchains/node/node] 3: 0x562ea729fc2c node::crypto::ScryptTraits::AdditionalConfig(node::crypto::CryptoJobMode, v8::FunctionCallbackInfo<v8::Value> const&, unsigned int, node::crypto::ScryptConfig*) [/home/zys/Toolchains/node/node] 4: 0x562ea72b33ad node::crypto::DeriveBitsJob<node::crypto::ScryptTraits>::New(v8::FunctionCallbackInfo<v8::Value> const&) [/home/zys/Toolchains/node/node] 5: 0x562ea7360167 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/home/zys/Toolchains/node/node] 6: 0x562ea7360be2 [/home/zys/Toolchains/node/node] 7: 0x562ea73614ad [/home/zys/Toolchains/node/node] 8: 0x562ea736179a v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/home/zys/Toolchains/node/node] 9: 0x562ea7cff259 [/home/zys/Toolchains/node/node] [1] 209342 abort (core dumped) /home/zys/Toolchains/node/node
The text was updated successfully, but these errors were encountered:
crypto: fix scrypt keylen validation
13e5047
Fixes: nodejs#38381
27beb38
c1d9b5b
Fixes: #38381 PR-URL: #38385 Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Successfully merging a pull request may close this issue.
What steps will reproduce the bug?
Setup a node instance,
and run the following javascript code.
Then the node instance occurs an abort.
How often does it reproduce? Is there a required condition?
This abort can always be triggered following the steps above.
What is the expected behavior?
If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.
What do you see instead?
Additional information
The text was updated successfully, but these errors were encountered: