-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node5: test-module-loading-error.js fails #3798
Comments
Fix link is 404. Currently the test checks against 'unknown file type'. Which is the new error desc? Ideally it would check for both. |
Yeah, sorry, renamed to sunos.patch, because there are some other platform related nits. Just check the directory (s|test-sunos.patch||). |
I found a special case was already being evaluated for linux, so I just refactored the test to allow for expecting multiple possible error messages per platform. |
As for the other platform related nits, they're inside dependencies, so I'll let someone else handle that (a bit out of my confidence zone). You might want to create another issue for that. |
- refactor test to accept multiple error messages per platform - add new message to be found in Solaris 11.3 as per nodejs#3798
- refactor test to accept multiple error messages per platform - add new message to be found in Solaris 11.3 as per #3798 PR-URL: #3855 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
- refactor test to accept multiple error messages per platform - add new message to be found in Solaris 11.3 as per #3798 PR-URL: #3855 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
- refactor test to accept multiple error messages per platform - add new message to be found in Solaris 11.3 as per #3798 PR-URL: #3855 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
- refactor test to accept multiple error messages per platform - add new message to be found in Solaris 11.3 as per #3798 PR-URL: #3855 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
- refactor test to accept multiple error messages per platform - add new message to be found in Solaris 11.3 as per #3798 PR-URL: #3855 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
- refactor test to accept multiple error messages per platform - add new message to be found in Solaris 11.3 as per #3798 PR-URL: #3855 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Closing, I'm fairly sure this was fixed in 9827814. |
test-module-loading-error.js fails on Solaris 11.3 because of expecting a historic? error message.
Fix: http://iws.cs.uni-magdeburg.de/~elkner/tmp/node5/test-sunos.patch
The text was updated successfully, but these errors were encountered: