-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promisified pipeline missing AbortSignal support #37321
Comments
@benjamingr FYI |
I can fix this in a week or so. @Linkgoron want to take a stab at this? |
I'll give it a shot. It currently essentially receives (...streams, callback) does it make sense to check if the last parameter is an AbortSignal (i.e. after the callback)? What about promisified stream.finished? Does it make sense to add AbortSignal support to it? In theory, you'd expect the consumed stream itself to have cancellation support, but I can see how someone might want to abort waiting. |
add support for AbortSignal to promisified pipeline. Resolves: nodejs#37321
add support for AbortSignal to promisified pipeline. Resolves: nodejs#37321
created PR #37359 |
add support for AbortSignal to promisified pipeline. Resolves: nodejs#37321
add support for AbortSignal to promisified pipeline. Resolves: nodejs#37321
add support for AbortSignal to promisified pipeline. Resolves: #37321 PR-URL: #37359 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
No description provided.
The text was updated successfully, but these errors were encountered: