Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-fs-write-file AssertionError #36090

Closed
rickyes opened this issue Nov 12, 2020 · 1 comment
Closed

test-fs-write-file AssertionError #36090

rickyes opened this issue Nov 12, 2020 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system.

Comments

@rickyes
Copy link
Contributor

rickyes commented Nov 12, 2020

  • Test: test-fs-write-file
  • Platform: arm-fanned
  • Console Output:
(node:24314) ExperimentalWarning: AbortController is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
node:assert:107
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

839 !== 0

    at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-write-file.js:64:16
    at /home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:342:17
    at /home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:377:15
    at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:73:3) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 839,
  expected: 0,
  operator: 'strictEqual'
}
@rickyes rickyes added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. fs Issues and PRs related to the fs subsystem / file system. and removed http2 Issues or PRs related to the http2 subsystem. labels Nov 12, 2020
@Trott
Copy link
Member

Trott commented Nov 12, 2020

I'm pretty sure this is due to re-use of a filename. Probable fix is in #36102. Fast-track would be great.

@Trott Trott closed this as completed in f03f7cb Nov 12, 2020
@gireeshpunathil gireeshpunathil mentioned this issue Nov 13, 2020
Merged
4 tasks
targos pushed a commit to targos/node that referenced this issue Apr 30, 2021
@Trott @targos
test: fix unreliable test-fs-write-file.js
9abc11a 
The test uses a file name twice, causing unreliability in CI. In
particular, it's failing a lot on the Raspberry Pi devices.

Fixes: nodejs#36090

PR-URL: nodejs#36102
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this issue Apr 30, 2021
@Trott @targos
test: fix unreliable test-fs-write-file.js
de654bf 
The test uses a file name twice, causing unreliability in CI. In
particular, it's failing a lot on the Raspberry Pi devices.

Fixes: #36090

PR-URL: #36102
Backport-PR-URL: #38386
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @rickyes