-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
illegal access error with Typescript compiled code #34361
Comments
Yeah, it would be great to know the missing lines before the |
Just happened again :D Actually I have 0 idea about this I would want to provide more details. But the output log is all I know. I will try to find what causes error or in which scenarios it happens.
|
An additional note: undefined: 0 output part is not part of my code. Plus, somehow vscode try to attach debug twice (I guess): There are two Debugger listening on ... lines. |
In the termination case, we should not crash. There’s also no harm being done by ignoring the termination exception here, since the thread is about to be torn down anyway. Also, add a guard against running this during shutdown. That is the likely cause of nodejs#34361. Fixes: nodejs#34361
@selimrecep I think #34362 should fix this … I don’t quite know how to reproduce this, so I’m having a hard time coming up with a regression test, but if there’s any chance that you could build Node.js with that PR and verify that it fixes this, that would be extremely helpful :) Either way, thanks for the bug report! |
In the termination case, we should not crash. There’s also no harm being done by ignoring the termination exception here, since the thread is about to be torn down anyway. Also, add a guard against running this during shutdown. That is the likely cause of #34361. Fixes: #34361 PR-URL: #34362 Fixes: #27261 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
In the termination case, we should not crash. There’s also no harm being done by ignoring the termination exception here, since the thread is about to be torn down anyway. Also, add a guard against running this during shutdown. That is the likely cause of #34361. Fixes: #34361 PR-URL: #34362 Fixes: #27261 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
In the termination case, we should not crash. There’s also no harm being done by ignoring the termination exception here, since the thread is about to be torn down anyway. Also, add a guard against running this during shutdown. That is the likely cause of #34361. Fixes: #34361 PR-URL: #34362 Fixes: #27261 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
I know it doesn't make sense but, random. Actually I have no idea what is this error about, but there is a text "please report this."
What is the expected behavior?
It should run without any issues.
What do you see instead?
Additional information
I am not sure what causes this. I will try to find what is wrong with my code or maybe node. But I am using Typescript with VSCode.
The text was updated successfully, but these errors were encountered: